mt76: mt7915: fix memleak when mt7915_unregister_device()
authorRyder Lee <ryder.lee@mediatek.com>
Tue, 13 Apr 2021 05:34:57 +0000 (13:34 +0800)
committerFelix Fietkau <nbd@nbd.name>
Wed, 21 Apr 2021 09:42:20 +0000 (11:42 +0200)
mt7915_tx_token_put() should get call before mt76_free_pending_txwi().

Fixes: f285dfb98562 ("mt76: mt7915: reset token when mac_reset happens")
Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7915/init.c

index 32c371055596dcb0f3e06e0d4e3781c76a072d8d..d242e186424dca31374822e33cdee41ef91a96c4 100644 (file)
@@ -740,9 +740,8 @@ void mt7915_unregister_device(struct mt7915_dev *dev)
        mt7915_unregister_ext_phy(dev);
        mt76_unregister_device(&dev->mt76);
        mt7915_mcu_exit(dev);
-       mt7915_dma_cleanup(dev);
-
        mt7915_tx_token_put(dev);
+       mt7915_dma_cleanup(dev);
 
        mt76_free_device(&dev->mt76);
 }