ASoC: renesas: rz-ssi: Rely on the ASoC subsystem to runtime resume/suspend the SSI
authorClaudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Tue, 10 Dec 2024 17:09:42 +0000 (19:09 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 11 Dec 2024 13:24:03 +0000 (13:24 +0000)
The ASoC subsystem takes care of runtime resume/suspend the audio
devices when needed. Just enable the runtime PM on the SSI driver and
let the subsystem runtime resume/suspend it. While at it use directly
the devm_pm_runtime_enable().

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Link: https://patch.msgid.link/20241210170953.2936724-14-claudiu.beznea.uj@bp.renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/renesas/rz-ssi.c

index 209b5b8827e50e4001e7001335c7b6e1507df824..878158344f88defcb94c921da47fe3fd2350b63c 100644 (file)
@@ -1140,11 +1140,10 @@ static int rz_ssi_probe(struct platform_device *pdev)
        }
 
        reset_control_deassert(ssi->rstc);
-       pm_runtime_enable(dev);
-       ret = pm_runtime_resume_and_get(dev);
+       ret = devm_pm_runtime_enable(dev);
        if (ret < 0) {
-               dev_err(dev, "pm_runtime_resume_and_get failed\n");
-               goto err_pm;
+               dev_err(dev, "Failed to enable runtime PM!\n");
+               goto err_reset;
        }
 
        ret = devm_snd_soc_register_component(dev, &rz_ssi_soc_component,
@@ -1152,15 +1151,12 @@ static int rz_ssi_probe(struct platform_device *pdev)
                                              ARRAY_SIZE(rz_ssi_soc_dai));
        if (ret < 0) {
                dev_err(dev, "failed to register snd component\n");
-               goto err_pm_put;
+               goto err_reset;
        }
 
        return 0;
 
-err_pm_put:
-       pm_runtime_put(dev);
-err_pm:
-       pm_runtime_disable(dev);
+err_reset:
        reset_control_assert(ssi->rstc);
 err_release_dma_chs:
        rz_ssi_release_dma_channels(ssi);
@@ -1174,8 +1170,6 @@ static void rz_ssi_remove(struct platform_device *pdev)
 
        rz_ssi_release_dma_channels(ssi);
 
-       pm_runtime_put(ssi->dev);
-       pm_runtime_disable(ssi->dev);
        reset_control_assert(ssi->rstc);
 }