nfsd: filecache: use nfsd_file_dispose_list() in nfsd_file_close_inode_sync()
authorNeilBrown <neilb@suse.de>
Tue, 18 Feb 2025 15:39:33 +0000 (10:39 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 10 Mar 2025 13:11:06 +0000 (09:11 -0400)
nfsd_file_close_inode_sync() contains an exact copy of
nfsd_file_dispose_list().

This patch removes that copy and calls nfsd_file_dispose_list()
instead.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/filecache.c

index b53fac36bb54055dedd254a58ee073e59cdf9ca2..604a2aef5ff70e4cb20d93c3adf89aab75362d7c 100644 (file)
@@ -672,17 +672,12 @@ nfsd_file_close_inode(struct inode *inode)
 void
 nfsd_file_close_inode_sync(struct inode *inode)
 {
-       struct nfsd_file *nf;
        LIST_HEAD(dispose);
 
        trace_nfsd_file_close(inode);
 
        nfsd_file_queue_for_close(inode, &dispose);
-       while (!list_empty(&dispose)) {
-               nf = list_first_entry(&dispose, struct nfsd_file, nf_gc);
-               list_del_init(&nf->nf_gc);
-               nfsd_file_free(nf);
-       }
+       nfsd_file_dispose_list(&dispose);
 }
 
 static int