drm/etnaviv: Clean up etnaviv_gem_get_pages
authorSui Jingfeng <suijingfeng@loongson.cn>
Mon, 2 Oct 2023 11:12:07 +0000 (19:12 +0800)
committerLucas Stach <l.stach@pengutronix.de>
Tue, 23 Jan 2024 09:20:20 +0000 (10:20 +0100)
As in the etnaviv_gem_get_pages() function, the point to the drm_device
has already been cached to the 'dev' local variable. We can use it
directly, While at it, using 'unsigned int' type to count the number of
pages. As the drm_prime_pages_to_sg() function takes an unsigned int type
for its third argument. No functional change.

Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
[lst: Reword subject to make more generic and match patch content]
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
drivers/gpu/drm/etnaviv/etnaviv_gem.c

index be2f459c66b5d9f6885c862747d088578f846039..71a6d2b1c80f5106c837b9968c4f9e069394a9c7 100644 (file)
@@ -100,11 +100,10 @@ struct page **etnaviv_gem_get_pages(struct etnaviv_gem_object *etnaviv_obj)
 
        if (!etnaviv_obj->sgt) {
                struct drm_device *dev = etnaviv_obj->base.dev;
-               int npages = etnaviv_obj->base.size >> PAGE_SHIFT;
+               unsigned int npages = etnaviv_obj->base.size >> PAGE_SHIFT;
                struct sg_table *sgt;
 
-               sgt = drm_prime_pages_to_sg(etnaviv_obj->base.dev,
-                                           etnaviv_obj->pages, npages);
+               sgt = drm_prime_pages_to_sg(dev, etnaviv_obj->pages, npages);
                if (IS_ERR(sgt)) {
                        dev_err(dev->dev, "failed to allocate sgt: %ld\n",
                                PTR_ERR(sgt));