pm80xx: Remove bogus address masking in pm8001_ioremap()
authorDavid Daney <david.daney@cavium.com>
Wed, 13 Apr 2016 21:26:56 +0000 (14:26 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 15 Apr 2016 20:53:18 +0000 (16:53 -0400)
It is unclear what the original intent of the masking was, but it is
clearly incorrect to truncate a physical address before calling
ioremap().  On systems where there are valid physical address bits above
bit-31 (arm64 for example) the result is an eventual OOPs when
initializing the driver.

Remove the bogus code to fix it.

Signed-off-by: David Daney <david.daney@cavium.com>
Acked-by: Jack Wang <jinpu.wang@profitbricks.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/pm8001/pm8001_init.c

index 062ab34b86f8bcab08d24b8cfe1e4dffa938939d..6bd7bf4f4a81776b01ff25652dfd4bc26014ee8d 100644 (file)
@@ -418,8 +418,6 @@ static int pm8001_ioremap(struct pm8001_hba_info *pm8001_ha)
                if (pci_resource_flags(pdev, bar) & IORESOURCE_MEM) {
                        pm8001_ha->io_mem[logicalBar].membase =
                                pci_resource_start(pdev, bar);
-                       pm8001_ha->io_mem[logicalBar].membase &=
-                               (u32)PCI_BASE_ADDRESS_MEM_MASK;
                        pm8001_ha->io_mem[logicalBar].memsize =
                                pci_resource_len(pdev, bar);
                        pm8001_ha->io_mem[logicalBar].memvirtaddr =