dpll: move xa_erase() call in to match dpll_pin_alloc() error path order
authorJiri Pirko <jiri@nvidia.com>
Tue, 30 Jan 2024 15:58:14 +0000 (16:58 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 31 Jan 2024 21:32:49 +0000 (13:32 -0800)
This is cosmetics. Move the call of xa_erase() in dpll_pin_put()
so the order of cleanup calls matches the error path of
dpll_pin_alloc().

Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Link: https://lore.kernel.org/r/20240130155814.268622-1-jiri@resnulli.us
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/dpll/dpll_core.c

index 5152bd1b0daf599869195e81805fbb2709dbe6b4..61e5c607a72f4cac0e7d81d5e9859da2ef4da5b9 100644 (file)
@@ -560,9 +560,9 @@ void dpll_pin_put(struct dpll_pin *pin)
 {
        mutex_lock(&dpll_lock);
        if (refcount_dec_and_test(&pin->refcount)) {
+               xa_erase(&dpll_pin_xa, pin->id);
                xa_destroy(&pin->dpll_refs);
                xa_destroy(&pin->parent_refs);
-               xa_erase(&dpll_pin_xa, pin->id);
                dpll_pin_prop_free(&pin->prop);
                kfree(pin);
        }