mlxbf_gige: return EPROBE_DEFER if PHY IRQ is not available
authorDavid Thompson <davthompson@nvidia.com>
Wed, 18 Jun 2025 13:59:02 +0000 (13:59 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 19 Jun 2025 15:34:59 +0000 (08:34 -0700)
The message "Error getting PHY irq. Use polling instead"
is emitted when the mlxbf_gige driver is loaded by the
kernel before the associated gpio-mlxbf driver, and thus
the call to get the PHY IRQ fails since it is not yet
available. The driver probe() must return -EPROBE_DEFER
if acpi_dev_gpio_irq_get_by() returns the same.

Fixes: 6c2a6ddca763 ("net: mellanox: mlxbf_gige: Replace non-standard interrupt handling")
Signed-off-by: David Thompson <davthompson@nvidia.com>
Reviewed-by: Asmaa Mnebhi <asmaa@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250618135902.346-1-davthompson@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c

index fb2e5b844c150d2f464be32977b1c32571630a8a..d76d7a945899c6c5fc6770e48f2d489f546cb772 100644 (file)
@@ -447,8 +447,10 @@ static int mlxbf_gige_probe(struct platform_device *pdev)
        priv->llu_plu_irq = platform_get_irq(pdev, MLXBF_GIGE_LLU_PLU_INTR_IDX);
 
        phy_irq = acpi_dev_gpio_irq_get_by(ACPI_COMPANION(&pdev->dev), "phy", 0);
-       if (phy_irq < 0) {
-               dev_err(&pdev->dev, "Error getting PHY irq. Use polling instead");
+       if (phy_irq == -EPROBE_DEFER) {
+               err = -EPROBE_DEFER;
+               goto out;
+       } else if (phy_irq < 0) {
                phy_irq = PHY_POLL;
        }