net: openvswitch: Annotate struct dp_meter_instance with __counted_by
authorKees Cook <keescook@chromium.org>
Fri, 22 Sep 2023 17:28:52 +0000 (10:28 -0700)
committerJakub Kicinski <kuba@kernel.org>
Mon, 2 Oct 2023 18:24:54 +0000 (11:24 -0700)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct dp_meter_instance.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Cc: Pravin B Shelar <pshelar@ovn.org>
Cc: dev@openvswitch.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20230922172858.3822653-10-keescook@chromium.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/openvswitch/meter.h

index 0c33889a85156997f5dc5067de3625ec83e9b479..013de694221f85bba8562d8c42a087e8486ad4d5 100644 (file)
@@ -45,7 +45,7 @@ struct dp_meter {
 struct dp_meter_instance {
        struct rcu_head rcu;
        u32 n_meters;
-       struct dp_meter __rcu *dp_meters[];
+       struct dp_meter __rcu *dp_meters[] __counted_by(n_meters);
 };
 
 struct dp_meter_table {