mailbox: hi3660: Use device-managed registration API
authorThierry Reding <treding@nvidia.com>
Thu, 20 Dec 2018 17:19:49 +0000 (18:19 +0100)
committerJassi Brar <jaswinder.singh@linaro.org>
Fri, 21 Dec 2018 22:49:25 +0000 (16:49 -0600)
Get rid of some boilerplate driver removal code by using the newly added
device-managed registration API.

Tested-by: Leo Yan <leo.yan@linaro.org>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
drivers/mailbox/hi3660-mailbox.c

index f9aed5d8f9f1ff36a282632f7838e3025e0c6cc6..53f4bc2488c50c3a91988f06195d3415dff9c54c 100644 (file)
@@ -265,7 +265,7 @@ static int hi3660_mbox_probe(struct platform_device *pdev)
        for (ch = 0; ch < MBOX_CHAN_MAX; ch++)
                chan[ch].con_priv = (void *)ch;
 
-       err = mbox_controller_register(&mbox->controller);
+       err = devm_mbox_controller_register(dev, &mbox->controller);
        if (err) {
                dev_err(dev, "Failed to register mailbox %d\n", err);
                return err;
@@ -276,17 +276,8 @@ static int hi3660_mbox_probe(struct platform_device *pdev)
        return 0;
 }
 
-static int hi3660_mbox_remove(struct platform_device *pdev)
-{
-       struct hi3660_mbox *mbox = platform_get_drvdata(pdev);
-
-       mbox_controller_unregister(&mbox->controller);
-       return 0;
-}
-
 static struct platform_driver hi3660_mbox_driver = {
        .probe  = hi3660_mbox_probe,
-       .remove = hi3660_mbox_remove,
        .driver = {
                .name = "hi3660-mbox",
                .of_match_table = hi3660_mbox_of_match,