ALSA: usb-audio: qcom: Fix an error handling path in qc_usb_audio_probe()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Fri, 9 May 2025 10:19:40 +0000 (12:19 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 21 May 2025 12:34:07 +0000 (14:34 +0200)
If an error occurs after a successful qc_usb_audio_offload_init_qmi_dev()
call, qc_usb_audio_cleanup_qmi_dev() should be called to release some
resources as already done in the remove function.

Add the missing qc_usb_audio_cleanup_qmi_dev().

Fixes: 326bbc348298 ("ALSA: usb-audio: qcom: Introduce QC USB SND offloading support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/335f54da099240d9b6c7aca0397c7d8c6bb629ac.1746785961.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/usb/qcom/qc_audio_offload.c

index 8b096f37ad4cc3e22495750d4d58536b3be96358..65ba4d90d438be8abb551bcc30d4af204decbb07 100644 (file)
@@ -1957,6 +1957,7 @@ static int qc_usb_audio_probe(struct auxiliary_device *auxdev,
        return 0;
 
 release_qmi:
+       qc_usb_audio_cleanup_qmi_dev();
        qmi_handle_release(svc->uaudio_svc_hdl);
 free_svc:
        kfree(svc);