jbd2: remove wrong sb->s_sequence check
authorJan Kara <jack@suse.cz>
Thu, 6 Feb 2025 09:46:58 +0000 (10:46 +0100)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 17 Mar 2025 15:19:41 +0000 (11:19 -0400)
Journal emptiness is not determined by sb->s_sequence == 0 but rather by
sb->s_start == 0 (which is set a few lines above). Furthermore 0 is a
valid transaction ID so the check can spuriously trigger. Remove the
invalid WARN_ON.

CC: stable@vger.kernel.org
Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Zhang Yi <yi.zhang@huawei.com>
Link: https://patch.msgid.link/20250206094657.20865-3-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/jbd2/journal.c

index d8084b31b3610a446a03089e7564806e8588f2fc..d210e8a82e666476925107f30255920f1eb230ee 100644 (file)
@@ -1869,7 +1869,6 @@ int jbd2_journal_update_sb_log_tail(journal_t *journal, tid_t tail_tid,
 
        /* Log is no longer empty */
        write_lock(&journal->j_state_lock);
-       WARN_ON(!sb->s_sequence);
        journal->j_flags &= ~JBD2_FLUSHED;
        write_unlock(&journal->j_state_lock);