thermal/debugfs: replace kzalloc() with kcalloc() in thermal_debug_tz_add()
authorEthan Carter Edwards <ethan@ethancedwards.com>
Sat, 22 Feb 2025 20:02:42 +0000 (15:02 -0500)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 26 Feb 2025 19:48:07 +0000 (20:48 +0100)
Work is under way to get rid of all multiplications from allocation
functions to prevent integer overflows [1].

Here the multiplication is obviously safe, but using kcalloc() is more
appropriate and improves readability.

This change has no effect on runtime behavior.

Link: https://github.com/KSPP/linux/issues/162
Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com>
Link: https://patch.msgid.link/20250222-thermal_kcalloc-v1-1-9f7a747fbed7@ethancedwards.com
[ rjw: Changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/thermal/thermal_debugfs.c

index c800504c3cfe0ea3b4a51286f348dd5802e1898f..60ee6c366998e26447a0b985112f578ba8757f17 100644 (file)
@@ -876,7 +876,7 @@ void thermal_debug_tz_add(struct thermal_zone_device *tz)
 
        tz_dbg->tz = tz;
 
-       tz_dbg->trips_crossed = kzalloc(sizeof(int) * tz->num_trips, GFP_KERNEL);
+       tz_dbg->trips_crossed = kcalloc(tz->num_trips, sizeof(int), GFP_KERNEL);
        if (!tz_dbg->trips_crossed) {
                thermal_debugfs_remove_id(thermal_dbg);
                return;