thermal: int340x: Use kcalloc() instead of kzalloc() with multiplication
authorLukasz Luba <lukasz.luba@arm.com>
Mon, 24 Feb 2025 17:33:05 +0000 (17:33 +0000)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 26 Feb 2025 19:55:42 +0000 (20:55 +0100)
According to the latest recommendations, kcalloc() should be used
instead of kzalloc() with multiplication (which might overflow).

Switch to this new scheme and use more safe kcalloc().

No functional impact.

Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
Link: https://patch.msgid.link/20250224173432.1946070-4-lukasz.luba@arm.com
[ rjw: Changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/thermal/intel/int340x_thermal/int340x_thermal_zone.c

index 8dca6a6aceca144700bea2837d8506ae57349667..2d672c4be3ce5fed8015ccf94f1ac077214acfdb 100644 (file)
@@ -133,8 +133,8 @@ struct int34x_thermal_zone *int340x_thermal_zone_add(struct acpi_device *adev,
        if (ACPI_SUCCESS(status))
                int34x_zone->aux_trip_nr = trip_cnt;
 
-       zone_trips = kzalloc(sizeof(*zone_trips) * (trip_cnt + INT340X_THERMAL_MAX_TRIP_COUNT),
-                            GFP_KERNEL);
+       zone_trips = kcalloc(trip_cnt + INT340X_THERMAL_MAX_TRIP_COUNT,
+                            sizeof(*zone_trips), GFP_KERNEL);
        if (!zone_trips) {
                ret = -ENOMEM;
                goto err_trips_alloc;