drm/amd/display: Fix check for null function ptr
authorAlvin Lee <Alvin.Lee2@amd.com>
Fri, 3 Dec 2021 21:29:05 +0000 (16:29 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 30 Dec 2021 13:54:44 +0000 (08:54 -0500)
[Why]
Bug fix for null function ptr (should check for NULL instead of not
NULL)

[How]
Fix if condition

Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Reviewed-by: Samson Tam <samson.tam@amd.com>
Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Signed-off-by: Alvin Lee <Alvin.Lee2@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dmub/src/dmub_srv.c

index f673a1c1777a7fe32dbafecf0c566a88678e4cea..9280f2abd97347fa4c9c0fd7c4a31c53dd9fdb77 100644 (file)
@@ -852,7 +852,7 @@ bool dmub_srv_should_detect(struct dmub_srv *dmub)
 
 enum dmub_status dmub_srv_clear_inbox0_ack(struct dmub_srv *dmub)
 {
-       if (!dmub->hw_init || dmub->hw_funcs.clear_inbox0_ack_register)
+       if (!dmub->hw_init || !dmub->hw_funcs.clear_inbox0_ack_register)
                return DMUB_STATUS_INVALID;
 
        dmub->hw_funcs.clear_inbox0_ack_register(dmub);
@@ -878,7 +878,7 @@ enum dmub_status dmub_srv_wait_for_inbox0_ack(struct dmub_srv *dmub, uint32_t ti
 enum dmub_status dmub_srv_send_inbox0_cmd(struct dmub_srv *dmub,
                union dmub_inbox0_data_register data)
 {
-       if (!dmub->hw_init || dmub->hw_funcs.send_inbox0_cmd)
+       if (!dmub->hw_init || !dmub->hw_funcs.send_inbox0_cmd)
                return DMUB_STATUS_INVALID;
 
        dmub->hw_funcs.send_inbox0_cmd(dmub, data);