bonding: uninitialized variable in bond_miimon_inspect()
authorDan Carpenter <error27@gmail.com>
Mon, 28 Nov 2022 11:06:14 +0000 (14:06 +0300)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 1 Dec 2022 09:47:36 +0000 (10:47 +0100)
The "ignore_updelay" variable needs to be initialized to false.

Fixes: f8a65ab2f3ff ("bonding: fix link recovery in mode 2 when updelay is nonzero")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>
Link: https://lore.kernel.org/r/Y4SWJlh3ohJ6EPTL@kili
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/bonding/bond_main.c

index c874810339955280bee90654b4fa615181eaa6d3..e01bb0412f1cb80ce1f4583a3933bea9b02652b7 100644 (file)
@@ -2524,10 +2524,10 @@ static int bond_slave_info_query(struct net_device *bond_dev, struct ifslave *in
 /* called with rcu_read_lock() */
 static int bond_miimon_inspect(struct bonding *bond)
 {
+       bool ignore_updelay = false;
        int link_state, commit = 0;
        struct list_head *iter;
        struct slave *slave;
-       bool ignore_updelay;
 
        if (BOND_MODE(bond) == BOND_MODE_ACTIVEBACKUP) {
                ignore_updelay = !rcu_dereference(bond->curr_active_slave);