PCI: Do not claim to release resource falsely
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Fri, 7 Mar 2025 14:09:22 +0000 (16:09 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 7 Mar 2025 17:26:19 +0000 (11:26 -0600)
pci_release_resource() will print "... releasing" regardless of the
resource being assigned or not. Move the print after the res->parent check
to avoid claiming the kernel would be releasing an unassigned resource.

Likely, none of the current callers pass a resource that is unassigned so
this change is mostly to correct the non-sensical order than to remove
errorneous printouts.

Link: https://lore.kernel.org/r/20250307140922.5776-1-ilpo.jarvinen@linux.intel.com
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
drivers/pci/setup-res.c

index b056acfda96ca0b95aca51d8f54182e703aec365..c6657cdd06f673d390018af574e133ca6a4b0566 100644 (file)
@@ -411,11 +411,11 @@ void pci_release_resource(struct pci_dev *dev, int resno)
        struct resource *res = pci_resource_n(dev, resno);
        const char *res_name = pci_resource_name(dev, resno);
 
-       pci_info(dev, "%s %pR: releasing\n", res_name, res);
-
        if (!res->parent)
                return;
 
+       pci_info(dev, "%s %pR: releasing\n", res_name, res);
+
        release_resource(res);
        res->end = resource_size(res) - 1;
        res->start = 0;