btrfs: make btrfs_block_rsv_full() check more boolean when starting transaction
authorFilipe Manana <fdmanana@suse.com>
Thu, 30 Mar 2023 14:39:02 +0000 (15:39 +0100)
committerDavid Sterba <dsterba@suse.com>
Mon, 17 Apr 2023 16:01:22 +0000 (18:01 +0200)
When starting a transaction we are comparing the result of a call to
btrfs_block_rsv_full() with 0, but the function returns a boolean. While
in practice it is not incorrect, as 0 is equivalent to false, it makes it
a bit odd and less readable. So update the check to not compare against 0
and instead use the logical not (!) operator.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/transaction.c

index c8e503e5db4cdb4eca29ca216202e9781f1e6243..c497886d30e67143ba22962cb06c5bcd1041c5c1 100644 (file)
@@ -607,7 +607,7 @@ start_transaction(struct btrfs_root *root, unsigned int num_items,
                 */
                num_bytes = btrfs_calc_insert_metadata_size(fs_info, num_items);
                if (flush == BTRFS_RESERVE_FLUSH_ALL &&
-                   btrfs_block_rsv_full(delayed_refs_rsv) == 0) {
+                   !btrfs_block_rsv_full(delayed_refs_rsv)) {
                        delayed_refs_bytes = num_bytes;
                        num_bytes <<= 1;
                }