PCI: aardvark: Fix return value of MSI domain .alloc() method
authorMarek Behún <kabel@kernel.org>
Thu, 28 Oct 2021 18:56:54 +0000 (20:56 +0200)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Fri, 29 Oct 2021 09:25:31 +0000 (10:25 +0100)
MSI domain callback .alloc() (implemented by advk_msi_irq_domain_alloc()
function) should return zero on success, since non-zero value indicates
failure.

When the driver was converted to generic MSI API in commit f21a8b1b6837
("PCI: aardvark: Move to MSI handling using generic MSI support"), it
was converted so that it returns hwirq number.

Fix this.

Link: https://lore.kernel.org/r/20211028185659.20329-3-kabel@kernel.org
Fixes: f21a8b1b6837 ("PCI: aardvark: Move to MSI handling using generic MSI support")
Signed-off-by: Pali Rohár <pali@kernel.org>
Signed-off-by: Marek Behún <kabel@kernel.org>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: stable@vger.kernel.org
drivers/pci/controller/pci-aardvark.c

index 10476c00b31268f60056dee5da70a5b62d929692..b45ff2911c80078ccf0cb4170f5c5a190bb13b58 100644 (file)
@@ -1138,7 +1138,7 @@ static int advk_msi_irq_domain_alloc(struct irq_domain *domain,
                                    domain->host_data, handle_simple_irq,
                                    NULL, NULL);
 
-       return hwirq;
+       return 0;
 }
 
 static void advk_msi_irq_domain_free(struct irq_domain *domain,