orangefs: fix mode handling

In 4053d2500beb ("orangefs: rework posix acl handling when creating new
filesystem objects") we tried to precalculate the correct mode when
creating a new inode. However, this leads to regressions when creating new
filesystem objects.

Even if we precalculate the mode we still need to call __orangefs_setattr()
to perform additional checks and we also need to update the mode of
ACL_TYPE_ACCESS acls set on the inode. The patch referenced above regressed
that. Restore that part of the old behavior and remove the mode
precalculation as it doesn't get us anything anymore.

Fixes: 4053d2500beb ("orangefs: rework posix acl handling when creating new filesystem objects")
Reported-by: Mike Marshall <hubcap@omnibond.com>
Signed-off-by: Christian Brauner (Microsoft) <brauner@kernel.org>

diff --git a/fs/orangefs/inode.c b/fs/orangefs/inode.c
index 8974b0fbf00dee6e06971668c521176c253eba56..3d65accfae17be3937811c0db105c55f5d24cc05 100644 (file)
--- a/fs/orangefs/inode.c
+++ b/fs/orangefs/inode.c
@@ -1131,7 +1131,7 @@ struct inode *orangefs_new_inode(struct super_block *sb, struct inode *dir,
        orangefs_set_inode(inode, ref);
        inode->i_ino = hash;    /* needed for stat etc */
 
-       error = __orangefs_inode_getattr(inode, mode, ORANGEFS_GETATTR_NEW);
+       error = orangefs_inode_getattr(inode, ORANGEFS_GETATTR_NEW);
        if (error)
                goto out_iput;
 
@@ -1158,6 +1158,15 @@ struct inode *orangefs_new_inode(struct super_block *sb, struct inode *dir,
        gossip_debug(GOSSIP_INODE_DEBUG,
                     "Initializing ACL's for inode %pU\n",
                     get_khandle_from_ino(inode));
+       if (mode != inode->i_mode) {
+               struct iattr iattr = {
+                       .ia_mode = mode,
+                       .ia_valid = ATTR_MODE,
+               };
+               inode->i_mode = mode;
+               __orangefs_setattr(inode, &iattr);
+               __posix_acl_chmod(&acl, GFP_KERNEL, inode->i_mode);
+       }
        posix_acl_release(acl);
        posix_acl_release(default_acl);
        return inode;

diff --git a/fs/orangefs/orangefs-kernel.h b/fs/orangefs/orangefs-kernel.h
index 55cd6d50eea1ab0d6bcdaf6e2e1639f040a2c81a..6e0cc01b3a14d2b3c5268b51e3adcad5c0fd456e 100644 (file)
--- a/fs/orangefs/orangefs-kernel.h
+++ b/fs/orangefs/orangefs-kernel.h
@@ -423,7 +423,6 @@ int orangefs_inode_setxattr(struct inode *inode,
 #define ORANGEFS_GETATTR_SIZE 2
 
 int orangefs_inode_getattr(struct inode *, int);
-int __orangefs_inode_getattr(struct inode *inode, umode_t mode, int flags);
 
 int orangefs_inode_check_changed(struct inode *inode);
 

diff --git a/fs/orangefs/orangefs-utils.c b/fs/orangefs/orangefs-utils.c
index 334a2fd98c37b4bd459876a72b13b5a06b6361f8..46b7dcff18acedaa3b9ca07ac8ad812b3a90748c 100644 (file)
--- a/fs/orangefs/orangefs-utils.c
+++ b/fs/orangefs/orangefs-utils.c
@@ -233,7 +233,7 @@ static int orangefs_inode_is_stale(struct inode *inode,
        return 0;
 }
 
-int __orangefs_inode_getattr(struct inode *inode, umode_t mode, int flags)
+int orangefs_inode_getattr(struct inode *inode, int flags)
 {
        struct orangefs_inode_s *orangefs_inode = ORANGEFS_I(inode);
        struct orangefs_kernel_op_s *new_op;
@@ -369,8 +369,7 @@ again2:
 
        /* special case: mark the root inode as sticky */
        inode->i_mode = type | (is_root_handle(inode) ? S_ISVTX : 0) |
-           orangefs_inode_perms(&new_op->downcall.resp.getattr.attributes) |
-           mode;
+           orangefs_inode_perms(&new_op->downcall.resp.getattr.attributes);
 
        orangefs_inode->getattr_time = jiffies +
            orangefs_getattr_timeout_msecs*HZ/1000;
@@ -382,11 +381,6 @@ out:
        return ret;
 }
 
-int orangefs_inode_getattr(struct inode *inode, int flags)
-{
-       return __orangefs_inode_getattr(inode, 0, flags);
-}
-
 int orangefs_inode_check_changed(struct inode *inode)
 {
        struct orangefs_inode_s *orangefs_inode = ORANGEFS_I(inode);