perf probe: Improve log for long event name failure

If a symbol name is longer than the maximum event length (64 bytes), the
perf tool reports error:

  # perf probe -x test_cpp_mangle --add "this_is_a_very_very_long_print_data_abcdefghijklmnopqrstuvwxyz(int)"
    snprintf() failed: -7; the event name nbase='this_is_a_very_very_long_print_data_abcdefghijklmnopqrstuvwxyz(int)' is too long
    Error: Failed to add events.

An information is missed in the log that the symbol name and the event
name can be set separately. Especially, this is recommended for adding
probe for a long symbol.

This commit refines the log for reminding event syntax.

After:

  # perf probe -x test_cpp_mangle --add "this_is_a_very_very_long_print_data_abcdefghijklmnopqrstuvwxyz(int)"
    snprintf() failed: -7; the event name 'this_is_a_very_very_long_print_data_abcdefghijklmnopqrstuvwxyz(int)' is too long
      Hint: Set a shorter event with syntax "EVENT=PROBEDEF"
            EVENT: Event name (max length: 64 bytes).
      Error: Failed to add events.

Signed-off-by: Leo Yan <leo.yan@arm.com>
Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Link: https://lore.kernel.org/r/20241012204725.928794-4-leo.yan@arm.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>

diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
index 2903341a430988de1b0b8cc5d741e32472b0d123..2c8d94d09e86c48c62c3e3330a8c75140b3116c0 100644 (file)
--- a/tools/perf/util/probe-event.c
+++ b/tools/perf/util/probe-event.c
@@ -2760,7 +2760,10 @@ static int get_new_event_name(char *buf, size_t len, const char *base,
        /* Try no suffix number */
        ret = e_snprintf(buf, len, "%s%s", nbase, ret_event ? "__return" : "");
        if (ret < 0) {
-               pr_warning("snprintf() failed: %d; the event name nbase='%s' is too long\n", ret, nbase);
+               pr_warning("snprintf() failed: %d; the event name '%s' is too long\n"
+                          "  Hint: Set a shorter event with syntax \"EVENT=PROBEDEF\"\n"
+                          "        EVENT: Event name (max length: %d bytes).\n",
+                          ret, nbase, MAX_EVENT_NAME_LEN);
                goto out;
        }
        if (!strlist__has_entry(namelist, buf))
@@ -2780,7 +2783,10 @@ static int get_new_event_name(char *buf, size_t len, const char *base,
        for (i = 1; i < MAX_EVENT_INDEX; i++) {
                ret = e_snprintf(buf, len, "%s_%d", nbase, i);
                if (ret < 0) {
-                       pr_debug("snprintf() failed: %d\n", ret);
+                       pr_warning("Add suffix failed: %d; the event name '%s' is too long\n"
+                                  "  Hint: Set a shorter event with syntax \"EVENT=PROBEDEF\"\n"
+                                  "        EVENT: Event name (max length: %d bytes).\n",
+                                  ret, nbase, MAX_EVENT_NAME_LEN);
                        goto out;
                }
                if (!strlist__has_entry(namelist, buf))