net: ena: Move reset completion print to the reset function
authorArthur Kiyanovski <akiyano@amazon.com>
Fri, 7 Jan 2022 20:23:42 +0000 (20:23 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sat, 8 Jan 2022 03:25:51 +0000 (19:25 -0800)
The print that indicates that device reset has finished is
currently called from ena_restore_device().

Move it to ena_fw_reset_device() as it is the more natural
location for it.

Signed-off-by: Shay Agroskin <shayagr@amazon.com>
Signed-off-by: Arthur Kiyanovski <akiyano@amazon.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/amazon/ena/ena_netdev.c

index 2dfb1ee378e5ab6213a8baf0f61a4544ba7759fe..b4e10f7082e2266e17eba875ee6ffe3684206d35 100644 (file)
@@ -3654,8 +3654,6 @@ static int ena_restore_device(struct ena_adapter *adapter)
        mod_timer(&adapter->timer_service, round_jiffies(jiffies + HZ));
        adapter->last_keep_alive_jiffies = jiffies;
 
-       dev_err(&pdev->dev, "Device reset completed successfully\n");
-
        return rc;
 err_disable_msix:
        ena_free_mgmnt_irq(adapter);
@@ -3685,6 +3683,8 @@ static void ena_fw_reset_device(struct work_struct *work)
        if (likely(test_bit(ENA_FLAG_TRIGGER_RESET, &adapter->flags))) {
                ena_destroy_device(adapter, false);
                ena_restore_device(adapter);
+
+               dev_err(&adapter->pdev->dev, "Device reset completed successfully\n");
        }
 
        rtnl_unlock();