chardev: Simplify usage of try_module_get()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 13 Oct 2023 13:24:42 +0000 (15:24 +0200)
committerChristian Brauner <brauner@kernel.org>
Thu, 19 Oct 2023 09:03:16 +0000 (11:03 +0200)
try_module_get(NULL) is true, so there is no need to check owner being
NULL.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231013132441.1406200-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/char_dev.c

index 950b6919fb872c191c58164000ffee249bc8a1b5..6ba032442b39d37e0d3901b6f7219237e8758c40 100644 (file)
@@ -350,7 +350,7 @@ static struct kobject *cdev_get(struct cdev *p)
        struct module *owner = p->owner;
        struct kobject *kobj;
 
-       if (owner && !try_module_get(owner))
+       if (!try_module_get(owner))
                return NULL;
        kobj = kobject_get_unless_zero(&p->kobj);
        if (!kobj)