blk-throttle: remove incorrect comment for tg_last_low_overflow_time
authorKemeng Shi <shikemeng@huawei.com>
Mon, 5 Dec 2022 11:57:07 +0000 (19:57 +0800)
committerJens Axboe <axboe@kernel.dk>
Mon, 5 Dec 2022 20:45:05 +0000 (13:45 -0700)
Function tg_last_low_overflow_time is called with intermediate node as
following:
throtl_hierarchy_can_downgrade
  throtl_tg_can_downgrade
    tg_last_low_overflow_time

throtl_hierarchy_can_upgrade
  throtl_tg_can_upgrade
    tg_last_low_overflow_time

throtl_hierarchy_can_downgrade/throtl_hierarchy_can_upgrade will traverse
from leaf node to sub-root node and pass traversed intermediate node
to tg_last_low_overflow_time.

No such limit could be found from context and implementation of
tg_last_low_overflow_time, so remove this limit in comment.

Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Kemeng Shi <shikemeng@huawei.com>
Link: https://lore.kernel.org/r/20221205115709.251489-8-shikemeng@huaweicloud.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-throttle.c

index 7db8592dae3873ec62160b5bad79312cb90dc4c9..e6a087de414dbd59db9936cc0c8374d8d686bc9e 100644 (file)
@@ -1762,7 +1762,6 @@ static unsigned long __tg_last_low_overflow_time(struct throtl_grp *tg)
        return min(rtime, wtime);
 }
 
-/* tg should not be an intermediate node */
 static unsigned long tg_last_low_overflow_time(struct throtl_grp *tg)
 {
        struct throtl_service_queue *parent_sq;