iio: adc: mp2629_adc: make use of regmap_clear_bits(), regmap_set_bits()

Instead of using regmap_update_bits() and passing the mask twice, use
regmap_set_bits().

Instead of using regmap_update_bits() and passing val = 0, use
regmap_clear_bits().

Suggested-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Signed-off-by: Trevor Gamblin <tgamblin@baylibre.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Link: https://patch.msgid.link/20240617-review-v3-14-88d1338c4cca@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/adc/mp2629_adc.c b/drivers/iio/adc/mp2629_adc.c
index 7c66c2cd5be21ffda5d1c1d70efd18ab78054ef1..5f672765d4a20e58dd4d564336faab8583b7ef64 100644 (file)
--- a/drivers/iio/adc/mp2629_adc.c
+++ b/drivers/iio/adc/mp2629_adc.c
@@ -131,9 +131,8 @@ static int mp2629_adc_probe(struct platform_device *pdev)
        info->dev = dev;
        platform_set_drvdata(pdev, indio_dev);
 
-       ret = regmap_update_bits(info->regmap, MP2629_REG_ADC_CTRL,
-                               MP2629_ADC_START | MP2629_ADC_CONTINUOUS,
-                               MP2629_ADC_START | MP2629_ADC_CONTINUOUS);
+       ret = regmap_set_bits(info->regmap, MP2629_REG_ADC_CTRL,
+                             MP2629_ADC_START | MP2629_ADC_CONTINUOUS);
        if (ret) {
                dev_err(dev, "adc enable fail: %d\n", ret);
                return ret;
@@ -163,10 +162,9 @@ fail_map_unregister:
        iio_map_array_unregister(indio_dev);
 
 fail_disable:
-       regmap_update_bits(info->regmap, MP2629_REG_ADC_CTRL,
-                                        MP2629_ADC_CONTINUOUS, 0);
-       regmap_update_bits(info->regmap, MP2629_REG_ADC_CTRL,
-                                        MP2629_ADC_START, 0);
+       regmap_clear_bits(info->regmap, MP2629_REG_ADC_CTRL,
+                         MP2629_ADC_CONTINUOUS);
+       regmap_clear_bits(info->regmap, MP2629_REG_ADC_CTRL, MP2629_ADC_START);
 
        return ret;
 }
@@ -180,10 +178,9 @@ static void mp2629_adc_remove(struct platform_device *pdev)
 
        iio_map_array_unregister(indio_dev);
 
-       regmap_update_bits(info->regmap, MP2629_REG_ADC_CTRL,
-                                        MP2629_ADC_CONTINUOUS, 0);
-       regmap_update_bits(info->regmap, MP2629_REG_ADC_CTRL,
-                                        MP2629_ADC_START, 0);
+       regmap_clear_bits(info->regmap, MP2629_REG_ADC_CTRL,
+                         MP2629_ADC_CONTINUOUS);
+       regmap_clear_bits(info->regmap, MP2629_REG_ADC_CTRL, MP2629_ADC_START);
 }
 
 static const struct of_device_id mp2629_adc_of_match[] = {