net: bgmac: make it clear when setting interface type to RMII
authorRafał Miłecki <rafal@milecki.pl>
Wed, 17 Aug 2016 21:11:52 +0000 (23:11 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Aug 2016 06:36:07 +0000 (23:36 -0700)
It doesn't really change anything as BGMAC_CHIPCTL_1_IF_TYPE_RMII is
equal to 0. It make code a bit clener, so far when reading it one could
think we forgot to set a proper mode. It also keeps this mode code in
sync with other ones.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bgmac.c

index 63ef72355833e01c3ebfefde97f65ff1a5b7e525..6ea0e5ff1e44a3b1f64721742edca855177e3978 100644 (file)
@@ -932,7 +932,8 @@ static void bgmac_chip_reset(struct bgmac *bgmac)
                        et_swtype <<= 4;
                        sw_type = et_swtype;
                } else if (bgmac->feature_flags & BGMAC_FEAT_SW_TYPE_EPHYRMII) {
-                       sw_type = BGMAC_CHIPCTL_1_SW_TYPE_EPHYRMII;
+                       sw_type = BGMAC_CHIPCTL_1_IF_TYPE_RMII |
+                                 BGMAC_CHIPCTL_1_SW_TYPE_EPHYRMII;
                } else if (bgmac->feature_flags & BGMAC_FEAT_SW_TYPE_RGMII) {
                        sw_type = BGMAC_CHIPCTL_1_IF_TYPE_RGMII |
                                  BGMAC_CHIPCTL_1_SW_TYPE_RGMII;