net: mana: Use mana_cleanup_port_context() for rxq cleanup
authorShradha Gupta <shradhagupta@linux.microsoft.com>
Fri, 14 Jun 2024 07:19:08 +0000 (00:19 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 18 Jun 2024 01:01:01 +0000 (18:01 -0700)
To cleanup rxqs in port context structures, instead of duplicating the
code, use existing function mana_cleanup_port_context() which does
the exact cleanup that's needed.

Signed-off-by: Shradha Gupta <shradhagupta@linux.microsoft.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Wei Liu <wei.liu@kernel.org>
Reviewed-by: Heng Qi <hengqi@linux.alibaba.com>
Link: https://lore.kernel.org/r/1718349548-28697-1-git-send-email-shradhagupta@linux.microsoft.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/microsoft/mana/mana_en.c

index b89ad4afd66eede51f01cf055382886ae1910bd9..93e526e5dd160ca733bd609aca6d1d083e7f6fab 100644 (file)
@@ -2529,8 +2529,7 @@ static int mana_init_port(struct net_device *ndev)
        return 0;
 
 reset_apc:
-       kfree(apc->rxqs);
-       apc->rxqs = NULL;
+       mana_cleanup_port_context(apc);
        return err;
 }
 
@@ -2787,8 +2786,7 @@ static int mana_probe_port(struct mana_context *ac, int port_idx,
 free_indir:
        mana_cleanup_indir_table(apc);
 reset_apc:
-       kfree(apc->rxqs);
-       apc->rxqs = NULL;
+       mana_cleanup_port_context(apc);
 free_net:
        *ndev_storage = NULL;
        netdev_err(ndev, "Failed to probe vPort %d: %d\n", port_idx, err);