net: phy: c45: use "supported_eee" instead of supported for access validation
authorOleksij Rempel <o.rempel@pengutronix.de>
Wed, 22 Feb 2023 05:50:40 +0000 (06:50 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 23 Feb 2023 12:43:23 +0000 (13:43 +0100)
Make sure we use proper variable to validate access to potentially not
supported registers. Otherwise we will get false read/write errors.

Reported-by: kernel test robot <yujie.liu@intel.com>
Link: https://lore.kernel.org/oe-lkp/202302211644.c12d19de-yujie.liu@intel.com
Fixes: 022c3f87f88e ("net: phy: add genphy_c45_ethtool_get/set_eee() support")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/phy/phy-c45.c

index f9b128cecc3f8af575467cc581781a96bb75e762..f23cce2c5199da25cb378543c219e30814f74d57 100644 (file)
@@ -674,7 +674,7 @@ int genphy_c45_write_eee_adv(struct phy_device *phydev, unsigned long *adv)
 {
        int val, changed;
 
-       if (linkmode_intersects(phydev->supported, PHY_EEE_CAP1_FEATURES)) {
+       if (linkmode_intersects(phydev->supported_eee, PHY_EEE_CAP1_FEATURES)) {
                val = linkmode_to_mii_eee_cap1_t(adv);
 
                /* In eee_broken_modes are stored MDIO_AN_EEE_ADV specific raw
@@ -726,7 +726,7 @@ static int genphy_c45_read_eee_adv(struct phy_device *phydev,
 {
        int val;
 
-       if (linkmode_intersects(phydev->supported, PHY_EEE_CAP1_FEATURES)) {
+       if (linkmode_intersects(phydev->supported_eee, PHY_EEE_CAP1_FEATURES)) {
                /* IEEE 802.3-2018 45.2.7.13 EEE advertisement 1
                 * (Register 7.60)
                 */
@@ -762,7 +762,7 @@ static int genphy_c45_read_eee_lpa(struct phy_device *phydev,
 {
        int val;
 
-       if (linkmode_intersects(phydev->supported, PHY_EEE_CAP1_FEATURES)) {
+       if (linkmode_intersects(phydev->supported_eee, PHY_EEE_CAP1_FEATURES)) {
                /* IEEE 802.3-2018 45.2.7.14 EEE link partner ability 1
                 * (Register 7.61)
                 */