mlxsw: spectrum: Remove unnecessary RCU read-side critical section
authorIdo Schimmel <idosch@nvidia.com>
Sun, 14 Mar 2021 12:19:37 +0000 (14:19 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sun, 14 Mar 2021 22:00:44 +0000 (15:00 -0700)
Since commit 7d8e8f3433dc ("mlxsw: core: Increase scope of RCU read-side
critical section"), all Rx handlers are called from an RCU read-side
critical section.

Remove the unnecessary rcu_read_lock() / rcu_read_unlock().

Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum.c

index 3b15f8d728a37e0685e30ee1ded80c6a18834b87..3d8e8d8dfff50cf7c37626799cb076d2a3986630 100644 (file)
@@ -2225,15 +2225,12 @@ void mlxsw_sp_sample_receive(struct mlxsw_sp *mlxsw_sp, struct sk_buff *skb,
                goto out;
        }
 
-       rcu_read_lock();
        sample = rcu_dereference(mlxsw_sp_port->sample);
        if (!sample)
-               goto out_unlock;
+               goto out;
        md.trunc_size = sample->truncate ? sample->trunc_size : skb->len;
        md.in_ifindex = mlxsw_sp_port->dev->ifindex;
        psample_sample_packet(sample->psample_group, skb, sample->rate, &md);
-out_unlock:
-       rcu_read_unlock();
 out:
        consume_skb(skb);
 }