mmc: pxamci: Use dma_request_chan() instead dma_request_slave_channel()
authorPeter Ujfalusi <peter.ujfalusi@ti.com>
Tue, 17 Dec 2019 11:30:04 +0000 (13:30 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Thu, 19 Dec 2019 07:19:42 +0000 (08:19 +0100)
dma_request_slave_channel() is a wrapper on top of dma_request_chan()
eating up the error code.

By using dma_request_chan() directly the driver can support deferred
probing against DMA.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/20191217113004.31688-1-peter.ujfalusi@ti.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/pxamci.c

index d38982abd26d8109ba05985e0a75fba5ddd71521..3a9333475a2b3c3eb0d06806ed01e740a8fa87d9 100644 (file)
@@ -710,17 +710,19 @@ static int pxamci_probe(struct platform_device *pdev)
 
        platform_set_drvdata(pdev, mmc);
 
-       host->dma_chan_rx = dma_request_slave_channel(dev, "rx");
-       if (host->dma_chan_rx == NULL) {
+       host->dma_chan_rx = dma_request_chan(dev, "rx");
+       if (IS_ERR(host->dma_chan_rx)) {
                dev_err(dev, "unable to request rx dma channel\n");
-               ret = -ENODEV;
+               ret = PTR_ERR(host->dma_chan_rx);
+               host->dma_chan_rx = NULL;
                goto out;
        }
 
-       host->dma_chan_tx = dma_request_slave_channel(dev, "tx");
-       if (host->dma_chan_tx == NULL) {
+       host->dma_chan_tx = dma_request_chan(dev, "tx");
+       if (IS_ERR(host->dma_chan_tx)) {
                dev_err(dev, "unable to request tx dma channel\n");
-               ret = -ENODEV;
+               ret = PTR_ERR(host->dma_chan_tx);
+               host->dma_chan_tx = NULL;
                goto out;
        }