media: dvb-frontends/lnbh25: improve kernellog output
authorDaniel Scheller <d.scheller@gmx.net>
Tue, 20 Jun 2017 19:57:24 +0000 (16:57 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Sat, 24 Jun 2017 20:05:19 +0000 (17:05 -0300)
Use dev_dbg() in conjunction with the %*ph format macro to print the vmon
status debug, thus hiding continuous hexdumping from default log levels.
Also, change the attach success log line from error to info severity.

Signed-off-by: Daniel Scheller <d.scheller@gmx.net>
Acked-by: Abylay Ospan <aospan@netup.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/dvb-frontends/lnbh25.c

index ef3021e964be89e61eeda59daa38d1e71fa7320c..cb486e879fdd3f50925dd8431a4d0a4de0e09d4d 100644 (file)
@@ -76,8 +76,8 @@ static int lnbh25_read_vmon(struct lnbh25_priv *priv)
                        return ret;
                }
        }
-       print_hex_dump_bytes("lnbh25_read_vmon: ",
-               DUMP_PREFIX_OFFSET, status, sizeof(status));
+       dev_dbg(&priv->i2c->dev, "%s(): %*ph\n",
+               __func__, (int) sizeof(status), status);
        if ((status[0] & (LNBH25_STATUS_OFL | LNBH25_STATUS_VMON)) != 0) {
                dev_err(&priv->i2c->dev,
                        "%s(): voltage in failure state, status reg 0x%x\n",
@@ -178,7 +178,7 @@ struct dvb_frontend *lnbh25_attach(struct dvb_frontend *fe,
        fe->ops.release_sec = lnbh25_release;
        fe->ops.set_voltage = lnbh25_set_voltage;
 
-       dev_err(&i2c->dev, "%s(): attached at I2C addr 0x%02x\n",
+       dev_info(&i2c->dev, "%s(): attached at I2C addr 0x%02x\n",
                __func__, priv->i2c_address);
        return fe;
 }