staging: rtl8723bs: change remaining printk to proper api

As part of TODO file for future work, use dyn debug api for
remaining printk statements.

Signed-off-by: Rodrigo Gobbi <rodrigo.gobbi.7@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20241029221544.112800-1-rodrigo.gobbi.7@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index 808f3a6e9014d065d14ad06f0f363296e7d4e233..bb639ce494315dba24f50707c60c87949352dc36 100644 (file)
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -1870,10 +1870,10 @@ unsigned int OnAction_sa_query(struct adapter *padapter, union recv_frame *precv
        if (0) {
                int pp;
 
-               printk("pattrib->pktlen = %d =>", pattrib->pkt_len);
+               netdev_dbg(padapter->pnetdev, "pattrib->pktlen = %d =>", pattrib->pkt_len);
                for (pp = 0; pp < pattrib->pkt_len; pp++)
-                       printk(" %02x ", pframe[pp]);
-               printk("\n");
+                       pr_cont(" %02x ", pframe[pp]);
+               pr_cont("\n");
        }
 
        return _SUCCESS;

diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c
index 0e266cef71d707f8a706066b305642c4a3f4cbaf..95fb38283c582a3af51a8aafd320cf18ca9110d7 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/hal_com.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com.c
@@ -893,10 +893,9 @@ void rtw_dump_raw_rssi_info(struct adapter *padapter)
 
        for (rf_path = 0; rf_path < pHalData->NumTotalRFPath; rf_path++) {
                if (!isCCKrate) {
-                       printk(", rx_ofdm_pwr:%d(dBm), rx_ofdm_snr:%d(dB)\n",
-                       psample_pkt_rssi->ofdm_pwr[rf_path], psample_pkt_rssi->ofdm_snr[rf_path]);
-               } else {
-                       printk("\n");
+                       netdev_dbg(padapter->pnetdev, ", rx_ofdm_pwr:%d(dBm), rx_ofdm_snr:%d(dB)\n",
+                                  psample_pkt_rssi->ofdm_pwr[rf_path],
+                                  psample_pkt_rssi->ofdm_snr[rf_path]);
                }
        }
 }

diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index c13919f058edbf91ccd878416e42ec7639fb7beb..be4cc8fc56968bec21ecd87a23e4b204c25f4972 100644 (file)
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -60,7 +60,8 @@ static int _BlockWrite(struct adapter *padapter, void *buffer, u32 buffSize)
        for (i = 0; i < blockCount_p1; i++) {
                ret = rtw_write32(padapter, (FW_8723B_START_ADDRESS + i * blockSize_p1), *((u32 *)(bufferPtr + i * blockSize_p1)));
                if (ret == _FAIL) {
-                       printk("====>%s %d i:%d\n", __func__, __LINE__, i);
+                       netdev_dbg(padapter->pnetdev, "write failed at %s %d, block:%d\n",
+                                  __func__, __LINE__, i);
                        goto exit;
                }
        }
@@ -83,7 +84,8 @@ static int _BlockWrite(struct adapter *padapter, void *buffer, u32 buffSize)
                        ret = rtw_write8(padapter, (FW_8723B_START_ADDRESS + offset + i), *(bufferPtr + offset + i));
 
                        if (ret == _FAIL) {
-                               printk("====>%s %d i:%d\n", __func__, __LINE__, i);
+                               netdev_dbg(padapter->pnetdev, "write failed at %s %d, block:%d\n",
+                                          __func__, __LINE__, i);
                                goto exit;
                        }
                }
@@ -125,7 +127,8 @@ static int _WriteFW(struct adapter *padapter, void *buffer, u32 size)
                ret = _PageWrite(padapter, page, bufferPtr+offset, MAX_DLFW_PAGE_SIZE);
 
                if (ret == _FAIL) {
-                       printk("====>%s %d\n", __func__, __LINE__);
+                       netdev_dbg(padapter->pnetdev, "page write failed at %s %d\n",
+                                  __func__, __LINE__);
                        goto exit;
                }
        }
@@ -136,7 +139,8 @@ static int _WriteFW(struct adapter *padapter, void *buffer, u32 size)
                ret = _PageWrite(padapter, page, bufferPtr+offset, remainSize);
 
                if (ret == _FAIL) {
-                       printk("====>%s %d\n", __func__, __LINE__);
+                       netdev_dbg(padapter->pnetdev, "remaining page write failed at %s %d\n",
+                                  __func__, __LINE__);
                        goto exit;
                }
        }

diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index 81867b98d793fe26cecb2cdf82d6aa686949bb20..5a7238e661ffbea6b0f0236a730f762a2e7abca2 100644 (file)
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -72,7 +72,7 @@ static int sdio_alloc_irq(struct dvobj_priv *dvobj)
        err = sdio_claim_irq(func, &sd_sync_int_hdl);
        if (err) {
                dvobj->drv_dbg.dbg_sdio_alloc_irq_error_cnt++;
-               printk(KERN_CRIT "%s: sdio_claim_irq FAIL(%d)!\n", __func__, err);
+               netdev_crit(dvobj->if1->pnetdev, "%s: sdio_claim_irq FAIL(%d)!\n", __func__, err);
        } else {
                dvobj->drv_dbg.dbg_sdio_alloc_irq_cnt++;
                dvobj->irq_alloc = 1;