irqchip/imx-irqsteer: Use dev_err_probe() to simplify error handling

dev_err_probe() can reduce code size, uniform error handling and record the
defer probe reason etc., use it to simplify the code.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/1597126576-18383-2-git-send-email-Anson.Huang@nxp.com

diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c
index 290531ec3d61eb00cff7ec393b885e49a6d5bba5..1edf7692a790bd15c41b00c5adde925817214911 100644 (file)
--- a/drivers/irqchip/irq-imx-irqsteer.c
+++ b/drivers/irqchip/irq-imx-irqsteer.c
@@ -158,12 +158,9 @@ static int imx_irqsteer_probe(struct platform_device *pdev)
        }
 
        data->ipg_clk = devm_clk_get(&pdev->dev, "ipg");
-       if (IS_ERR(data->ipg_clk)) {
-               ret = PTR_ERR(data->ipg_clk);
-               if (ret != -EPROBE_DEFER)
-                       dev_err(&pdev->dev, "failed to get ipg clk: %d\n", ret);
-               return ret;
-       }
+       if (IS_ERR(data->ipg_clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(data->ipg_clk),
+                                    "failed to get ipg clk\n");
 
        raw_spin_lock_init(&data->lock);