perf trace beauty open flags: Move RDRW to the start of the output
authorArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 14 Jul 2017 17:23:17 +0000 (14:23 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Wed, 19 Jul 2017 02:14:00 +0000 (23:14 -0300)
We were getting:

 62597.859 ( 0.005 ms): TaskSchedulerF/18107 fcntl(fd: 194, cmd: GETFL) = LARGEFILE|RDWR

Instead of the more familiar (from looking at strace output):

 62597.859 ( 0.005 ms): TaskSchedulerF/18107 fcntl(fd: 194, cmd: GETFL) = RDWR|LARGEFILE

Fix it.

Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/n/tip-d4d9nd88t4bu9y9odbrcb5z6@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/trace/beauty/open_flags.c

index e520112fdb6eaa657b97c3ce8bed50e219f4169d..3c20683d8cfb8a04c7f87bbc55532976196267ae 100644 (file)
@@ -33,6 +33,7 @@ size_t open__scnprintf_flags(unsigned long flags, char *bf, size_t size)
                flags &= ~O_##n; \
        }
 
+       P_FLAG(RDWR);
        P_FLAG(APPEND);
        P_FLAG(ASYNC);
        P_FLAG(CLOEXEC);
@@ -53,7 +54,6 @@ size_t open__scnprintf_flags(unsigned long flags, char *bf, size_t size)
 #ifdef O_PATH
        P_FLAG(PATH);
 #endif
-       P_FLAG(RDWR);
 #ifdef O_DSYNC
        if ((flags & O_SYNC) == O_SYNC)
                printed += scnprintf(bf + printed, size - printed, "%s%s", printed ? "|" : "", "SYNC");