bcachefs: Improve some error messages
authorKent Overstreet <kent.overstreet@gmail.com>
Sat, 24 Oct 2020 20:37:17 +0000 (16:37 -0400)
committerKent Overstreet <kent.overstreet@linux.dev>
Sun, 22 Oct 2023 21:08:45 +0000 (17:08 -0400)
Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/btree_io.c

index 996fc0c34b3c6d4b99fc6f8a1804c29b46d74a53..eebab3d08c0dd2bde0dcba0c3d62ec3d19c60260 100644 (file)
@@ -750,7 +750,9 @@ static int validate_bset(struct bch_fs *c, struct btree *b,
 
                btree_err_on(bkey_cmp(bn->max_key, b->key.k.p),
                             BTREE_ERR_MUST_RETRY, c, b, i,
-                            "incorrect max key");
+                            "incorrect max key %llu:%llu",
+                            bn->max_key.inode,
+                            bn->max_key.offset);
 
                if (write)
                        compat_btree_node(b->c.level, b->c.btree_id, version,
@@ -930,7 +932,8 @@ int bch2_btree_node_read_done(struct bch_fs *c, struct btree *b, bool have_retry
 
                        btree_err_on(!bch2_checksum_type_valid(c, BSET_CSUM_TYPE(i)),
                                     BTREE_ERR_WANT_RETRY, c, b, i,
-                                    "unknown checksum type");
+                                    "unknown checksum type %llu",
+                                    BSET_CSUM_TYPE(i));
 
                        nonce = btree_nonce(i, b->written << 9);
                        csum = csum_vstruct(c, BSET_CSUM_TYPE(i), nonce, b->data);
@@ -957,7 +960,8 @@ int bch2_btree_node_read_done(struct bch_fs *c, struct btree *b, bool have_retry
 
                        btree_err_on(!bch2_checksum_type_valid(c, BSET_CSUM_TYPE(i)),
                                     BTREE_ERR_WANT_RETRY, c, b, i,
-                                    "unknown checksum type");
+                                    "unknown checksum type %llu",
+                                    BSET_CSUM_TYPE(i));
 
                        nonce = btree_nonce(i, b->written << 9);
                        csum = csum_vstruct(c, BSET_CSUM_TYPE(i), nonce, bne);