kfifo: fix kfifo_alloc() and kfifo_init()
authorStefani Seibold <stefani@seibold.net>
Thu, 28 Feb 2013 01:05:51 +0000 (17:05 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 28 Feb 2013 03:10:23 +0000 (19:10 -0800)
Fix kfifo_alloc() and kfifo_init() to alloc at least the requested number
of elements.  Since the kfifo operates on power of 2 the request size will
be rounded up to the next power of two.

Signed-off-by: Stefani Seibold <stefani@seibold.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
lib/kfifo.c

index 59dcf5b81d24eae5580638547fbbe026a18566f2..7b7f83027b7b748a4a1497d7804d4b54077d0790 100644 (file)
@@ -42,8 +42,7 @@ int __kfifo_alloc(struct __kfifo *fifo, unsigned int size,
         * round down to the next power of 2, since our 'let the indices
         * wrap' technique works only in this case.
         */
-       if (!is_power_of_2(size))
-               size = rounddown_pow_of_two(size);
+       size = roundup_pow_of_two(size);
 
        fifo->in = 0;
        fifo->out = 0;
@@ -83,8 +82,7 @@ int __kfifo_init(struct __kfifo *fifo, void *buffer,
 {
        size /= esize;
 
-       if (!is_power_of_2(size))
-               size = rounddown_pow_of_two(size);
+       size = roundup_pow_of_two(size);
 
        fifo->in = 0;
        fifo->out = 0;