xfs: remove the mappedbno argument to xfs_attr3_leaf_read
authorChristoph Hellwig <hch@lst.de>
Wed, 20 Nov 2019 17:46:02 +0000 (09:46 -0800)
committerDarrick J. Wong <darrick.wong@oracle.com>
Fri, 22 Nov 2019 16:17:09 +0000 (08:17 -0800)
This argument is always hard coded to -1, so remove it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/libxfs/xfs_attr.c
fs/xfs/libxfs/xfs_attr_leaf.c
fs/xfs/libxfs/xfs_attr_leaf.h
fs/xfs/xfs_attr_list.c

index 510ca69746042b3a86fdd5a4897609fbf80d8280..ebe6b0575f408f4b830e692c6ccc563f59844873 100644 (file)
@@ -589,7 +589,7 @@ xfs_attr_leaf_addname(
         */
        dp = args->dp;
        args->blkno = 0;
-       error = xfs_attr3_leaf_read(args->trans, args->dp, args->blkno, -1, &bp);
+       error = xfs_attr3_leaf_read(args->trans, args->dp, args->blkno, &bp);
        if (error)
                return error;
 
@@ -715,7 +715,7 @@ xfs_attr_leaf_addname(
                 * remove the "old" attr from that block (neat, huh!)
                 */
                error = xfs_attr3_leaf_read(args->trans, args->dp, args->blkno,
-                                          -1, &bp);
+                                          &bp);
                if (error)
                        return error;
 
@@ -769,7 +769,7 @@ xfs_attr_leaf_removename(
         */
        dp = args->dp;
        args->blkno = 0;
-       error = xfs_attr3_leaf_read(args->trans, args->dp, args->blkno, -1, &bp);
+       error = xfs_attr3_leaf_read(args->trans, args->dp, args->blkno, &bp);
        if (error)
                return error;
 
@@ -813,7 +813,7 @@ xfs_attr_leaf_get(xfs_da_args_t *args)
        trace_xfs_attr_leaf_get(args);
 
        args->blkno = 0;
-       error = xfs_attr3_leaf_read(args->trans, args->dp, args->blkno, -1, &bp);
+       error = xfs_attr3_leaf_read(args->trans, args->dp, args->blkno, &bp);
        if (error)
                return error;
 
@@ -1173,7 +1173,7 @@ xfs_attr_node_removename(
                ASSERT(state->path.blk[0].bp);
                state->path.blk[0].bp = NULL;
 
-               error = xfs_attr3_leaf_read(args->trans, args->dp, 0, -1, &bp);
+               error = xfs_attr3_leaf_read(args->trans, args->dp, 0, &bp);
                if (error)
                        goto out;
 
index 86155260d8b9f828fa24d6ad70762b0804588dc4..2d17ed342a962ea6ebc0ba1e831da709a1044adf 100644 (file)
@@ -430,13 +430,12 @@ xfs_attr3_leaf_read(
        struct xfs_trans        *tp,
        struct xfs_inode        *dp,
        xfs_dablk_t             bno,
-       xfs_daddr_t             mappedbno,
        struct xfs_buf          **bpp)
 {
        int                     err;
 
-       err = xfs_da_read_buf(tp, dp, bno, mappedbno, bpp,
-                               XFS_ATTR_FORK, &xfs_attr3_leaf_buf_ops);
+       err = xfs_da_read_buf(tp, dp, bno, -1, bpp, XFS_ATTR_FORK,
+                       &xfs_attr3_leaf_buf_ops);
        if (!err && tp && *bpp)
                xfs_trans_buf_set_type(tp, *bpp, XFS_BLFT_ATTR_LEAF_BUF);
        return err;
@@ -1159,7 +1158,7 @@ xfs_attr3_leaf_to_node(
        error = xfs_da_grow_inode(args, &blkno);
        if (error)
                goto out;
-       error = xfs_attr3_leaf_read(args->trans, dp, 0, -1, &bp1);
+       error = xfs_attr3_leaf_read(args->trans, dp, 0, &bp1);
        if (error)
                goto out;
 
@@ -1996,7 +1995,7 @@ xfs_attr3_leaf_toosmall(
                if (blkno == 0)
                        continue;
                error = xfs_attr3_leaf_read(state->args->trans, state->args->dp,
-                                       blkno, -1, &bp);
+                                       blkno, &bp);
                if (error)
                        return error;
 
@@ -2732,7 +2731,7 @@ xfs_attr3_leaf_clearflag(
        /*
         * Set up the operation.
         */
-       error = xfs_attr3_leaf_read(args->trans, args->dp, args->blkno, -1, &bp);
+       error = xfs_attr3_leaf_read(args->trans, args->dp, args->blkno, &bp);
        if (error)
                return error;
 
@@ -2799,7 +2798,7 @@ xfs_attr3_leaf_setflag(
        /*
         * Set up the operation.
         */
-       error = xfs_attr3_leaf_read(args->trans, args->dp, args->blkno, -1, &bp);
+       error = xfs_attr3_leaf_read(args->trans, args->dp, args->blkno, &bp);
        if (error)
                return error;
 
@@ -2861,7 +2860,7 @@ xfs_attr3_leaf_flipflags(
        /*
         * Read the block containing the "old" attr
         */
-       error = xfs_attr3_leaf_read(args->trans, args->dp, args->blkno, -1, &bp1);
+       error = xfs_attr3_leaf_read(args->trans, args->dp, args->blkno, &bp1);
        if (error)
                return error;
 
@@ -2870,7 +2869,7 @@ xfs_attr3_leaf_flipflags(
         */
        if (args->blkno2 != args->blkno) {
                error = xfs_attr3_leaf_read(args->trans, args->dp, args->blkno2,
-                                          -1, &bp2);
+                                          &bp2);
                if (error)
                        return error;
        } else {
index 16208a7743dfac4856199df44498118727efc0ab..f4a188e28b7b692dce5c3cc46af0c962a290ad61 100644 (file)
@@ -108,8 +108,7 @@ int xfs_attr_leaf_order(struct xfs_buf *leaf1_bp,
                                   struct xfs_buf *leaf2_bp);
 int    xfs_attr_leaf_newentsize(struct xfs_da_args *args, int *local);
 int    xfs_attr3_leaf_read(struct xfs_trans *tp, struct xfs_inode *dp,
-                       xfs_dablk_t bno, xfs_daddr_t mappedbno,
-                       struct xfs_buf **bpp);
+                       xfs_dablk_t bno, struct xfs_buf **bpp);
 void   xfs_attr3_leaf_hdr_from_disk(struct xfs_da_geometry *geo,
                                     struct xfs_attr3_icleaf_hdr *to,
                                     struct xfs_attr_leafblock *from);
index 7a099df88a0c693e4d2ffc229838c904bccdcedc..fe914368ea7e8738af1a1ad8c675630515101f4a 100644 (file)
@@ -377,7 +377,8 @@ xfs_attr_node_list(
                        break;
                cursor->blkno = leafhdr.forw;
                xfs_trans_brelse(context->tp, bp);
-               error = xfs_attr3_leaf_read(context->tp, dp, cursor->blkno, -1, &bp);
+               error = xfs_attr3_leaf_read(context->tp, dp, cursor->blkno,
+                                           &bp);
                if (error)
                        return error;
        }
@@ -495,7 +496,7 @@ xfs_attr_leaf_list(xfs_attr_list_context_t *context)
        trace_xfs_attr_leaf_list(context);
 
        context->cursor->blkno = 0;
-       error = xfs_attr3_leaf_read(context->tp, context->dp, 0, -1, &bp);
+       error = xfs_attr3_leaf_read(context->tp, context->dp, 0, &bp);
        if (error)
                return error;