crypto: ahash - Fix infinite recursion in ahash_def_finup
authorHerbert Xu <herbert@gondor.apana.org.au>
Mon, 16 Jun 2025 04:09:17 +0000 (12:09 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 18 Jun 2025 09:02:02 +0000 (17:02 +0800)
Invoke the final function directly in the default finup implementation
since crypto_ahash_final is now just a wrapper around finup.

Reported-by: Eric Biggers <ebiggers@kernel.org>
Fixes: 9d7a0ab1c753 ("crypto: ahash - Handle partial blocks in API")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto/ahash.c

index e10bc2659ae4f559504dbf7cfb7ab258b0bb99d9..bc84a07c924c3bea4999f199f628668146c35ddf 100644 (file)
@@ -600,12 +600,14 @@ static void ahash_def_finup_done2(void *data, int err)
 
 static int ahash_def_finup_finish1(struct ahash_request *req, int err)
 {
+       struct crypto_ahash *tfm = crypto_ahash_reqtfm(req);
+
        if (err)
                goto out;
 
        req->base.complete = ahash_def_finup_done2;
 
-       err = crypto_ahash_final(req);
+       err = crypto_ahash_alg(tfm)->final(req);
        if (err == -EINPROGRESS || err == -EBUSY)
                return err;