spi: mchp-pci1xxxx: release resources on error in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 13 Feb 2024 18:07:45 +0000 (21:07 +0300)
committerMark Brown <broonie@kernel.org>
Tue, 13 Feb 2024 18:17:39 +0000 (18:17 +0000)
Call pci_release_regions(pdev) before returning on this error path.

Fixes: 3e7cfd6ad29a ("spi: mchp-pci1xxxx: Add support for DMA in SPI")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://msgid.link/r/efc92197-4023-4bfe-bc63-452e7ed112e8@moroto.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-pci1xxxx.c

index a99db6163aec06d424465a6248b3abe446771db5..969965d7bc98b538c6a9a0aa710e2083c7a4925a 100644 (file)
@@ -776,7 +776,7 @@ static int pci1xxxx_spi_probe(struct pci_dev *pdev, const struct pci_device_id *
 
                        ret = pci1xxxx_spi_dma_init(spi_bus, spi_sub_ptr->irq);
                        if (ret && ret != -EOPNOTSUPP)
-                               return ret;
+                               goto error;
 
                        /* This register is only applicable for 1st instance */
                        regval = readl(spi_bus->reg_base + SPI_PCI_CTRL_REG_OFFSET(0));