drm/msm/dp: Remove aux_cfg_update_done and related code
authorStephen Boyd <swboyd@chromium.org>
Tue, 29 Aug 2023 18:47:29 +0000 (11:47 -0700)
committerDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Mon, 9 Oct 2023 09:17:46 +0000 (12:17 +0300)
The member 'aux_cfg_update_done' is always false. This is dead code that
never runs. Remove it.

Cc: Vinod Polimera <quic_vpolimer@quicinc.com>
Cc: Kuogee Hsieh <quic_khsieh@quicinc.com>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Tested-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
Reviewed-by: Kuogee Hsieh <quic_khsieh@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/554985/
Link: https://lore.kernel.org/r/20230829184735.2841739-5-swboyd@chromium.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
drivers/gpu/drm/msm/dp/dp_panel.c

index 9fb4e963fefb55623a8f7cc812291a9ebce04c91..0893522ae1583110e524fb7e7c0ec09e95f9ab08 100644 (file)
@@ -17,7 +17,6 @@ struct dp_panel_private {
        struct dp_link *link;
        struct dp_catalog *catalog;
        bool panel_on;
-       bool aux_cfg_update_done;
 };
 
 static void dp_panel_read_psr_cap(struct dp_panel_private *panel)
@@ -177,19 +176,6 @@ int dp_panel_read_sink_caps(struct dp_panel *dp_panel,
                }
        }
 
-       if (panel->aux_cfg_update_done) {
-               drm_dbg_dp(panel->drm_dev,
-                               "read DPCD with updated AUX config\n");
-               rc = dp_panel_read_dpcd(dp_panel);
-               bw_code = drm_dp_link_rate_to_bw_code(dp_panel->link_info.rate);
-               if (rc || !is_link_rate_valid(bw_code) ||
-                       !is_lane_count_valid(dp_panel->link_info.num_lanes)
-                       || (bw_code > dp_panel->max_bw_code)) {
-                       DRM_ERROR("read dpcd failed %d\n", rc);
-                       return rc;
-               }
-               panel->aux_cfg_update_done = false;
-       }
 end:
        return rc;
 }
@@ -434,7 +420,6 @@ struct dp_panel *dp_panel_get(struct dp_panel_in *in)
 
        dp_panel = &panel->dp_panel;
        dp_panel->max_bw_code = DP_LINK_BW_8_1;
-       panel->aux_cfg_update_done = false;
 
        return dp_panel;
 }