powerpc: Use NULL instead of 0 for null pointers
authorBenjamin Gray <bgray@linux.ibm.com>
Wed, 11 Oct 2023 05:37:03 +0000 (16:37 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Thu, 19 Oct 2023 06:12:47 +0000 (17:12 +1100)
Sparse reports several uses of 0 for pointer arguments and comparisons.
Replace with NULL to better convey the intent. Remove entirely if a
comparison to follow the kernel style of implicit boolean conversions.

Signed-off-by: Benjamin Gray <bgray@linux.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20231011053711.93427-5-bgray@linux.ibm.com
arch/powerpc/kernel/setup_64.c
arch/powerpc/kvm/book3s_xive_native.c
arch/powerpc/net/bpf_jit_comp.c
arch/powerpc/perf/imc-pmu.c
arch/powerpc/platforms/4xx/soc.c
arch/powerpc/platforms/pseries/lpar.c

index 246201d0d879eff5bff8d90df4e4d6b8f282b8ac..2f19d5e9448522a390fd70ddbfb64220b5ce705b 100644 (file)
@@ -364,7 +364,7 @@ void __init early_setup(unsigned long dt_ptr)
         */
        initialise_paca(&boot_paca, 0);
        fixup_boot_paca(&boot_paca);
-       WARN_ON(local_paca != 0);
+       WARN_ON(local_paca);
        setup_paca(&boot_paca); /* install the paca into registers */
 
        /* -------- printk is now safe to use ------- */
index 712ab91ced3980397327daecc5a9c3a01505b38d..6e2ebbd8aaace81c4566aa106ca88d131de2cc0e 100644 (file)
@@ -567,7 +567,7 @@ static int kvmppc_xive_native_set_queue_config(struct kvmppc_xive *xive,
        u8 priority;
        struct kvm_ppc_xive_eq kvm_eq;
        int rc;
-       __be32 *qaddr = 0;
+       __be32 *qaddr = NULL;
        struct page *page;
        struct xive_q *q;
        gfn_t gfn;
index 37043dfc1adddf67b84f881fe751216db87162ec..471e37cf8e2a493255e1825b2127e98ae493f94e 100644 (file)
@@ -146,9 +146,9 @@ struct bpf_prog *bpf_int_jit_compile(struct bpf_prog *fp)
         * update ctgtx.idx as it pretends to output instructions, then we can
         * calculate total size from idx.
         */
-       bpf_jit_build_prologue(0, &cgctx);
+       bpf_jit_build_prologue(NULL, &cgctx);
        addrs[fp->len] = cgctx.idx * 4;
-       bpf_jit_build_epilogue(0, &cgctx);
+       bpf_jit_build_epilogue(NULL, &cgctx);
 
        fixup_len = fp->aux->num_exentries * BPF_FIXUP_LEN * 4;
        extable_len = fp->aux->num_exentries * sizeof(struct exception_table_entry);
index 9d229ef7f86efa3b085cba41931f4b4c544f51d3..eba2baabccb03a822a19491a07f89fd121c8ff7a 100644 (file)
@@ -544,7 +544,7 @@ static int nest_imc_event_init(struct perf_event *event)
                        break;
                }
                pcni++;
-       } while (pcni->vbase != 0);
+       } while (pcni->vbase);
 
        if (!flag)
                return -ENODEV;
index b2d940437a662e0e2e3c3c713a75953e14160ff4..5412e6b21e1065e944547e1a6adc130ac9b66166 100644 (file)
@@ -112,7 +112,7 @@ static int __init ppc4xx_l2c_probe(void)
        }
 
        /* Install error handler */
-       if (request_irq(irq, l2c_error_handler, 0, "L2C", 0) < 0) {
+       if (request_irq(irq, l2c_error_handler, 0, "L2C", NULL) < 0) {
                printk(KERN_ERR "Cannot install L2C error handler"
                       ", cache is not enabled\n");
                of_node_put(np);
index f2cb62148f36f464f559225603d1cf72227cd70e..b4e86b7ea584dfd9d4100610b84b705a774e8bea 100644 (file)
@@ -192,9 +192,9 @@ static void free_dtl_buffers(unsigned long *time_limit)
                        continue;
                kmem_cache_free(dtl_cache, pp->dispatch_log);
                pp->dtl_ridx = 0;
-               pp->dispatch_log = 0;
-               pp->dispatch_log_end = 0;
-               pp->dtl_curr = 0;
+               pp->dispatch_log = NULL;
+               pp->dispatch_log_end = NULL;
+               pp->dtl_curr = NULL;
 
                if (time_limit && time_after(jiffies, *time_limit)) {
                        cond_resched();
@@ -223,7 +223,7 @@ static void destroy_cpu_associativity(void)
 {
        kfree(vcpu_associativity);
        kfree(pcpu_associativity);
-       vcpu_associativity = pcpu_associativity = 0;
+       vcpu_associativity = pcpu_associativity = NULL;
 }
 
 static __be32 *__get_cpu_associativity(int cpu, __be32 *cpu_assoc, int flag)