net: dsa: mv88e6xxx: Fix off by in one in mv88e6185_phylink_get_caps()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 7 Feb 2022 08:22:53 +0000 (11:22 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 7 Feb 2022 12:35:10 +0000 (12:35 +0000)
The <= ARRAY_SIZE() needs to be < ARRAY_SIZE() to prevent an out of
bounds error.

Fixes: d4ebf12bcec4 ("net: dsa: mv88e6xxx: populate supported_interfaces and mac_capabilities")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/mv88e6xxx/chip.c

index 7670796c2aa14afa79ce4b25dcf30c283a35783f..192a7688b4df1ae8f80560d8000dc981399a3409 100644 (file)
@@ -585,7 +585,7 @@ static void mv88e6185_phylink_get_caps(struct mv88e6xxx_chip *chip, int port,
 {
        u8 cmode = chip->ports[port].cmode;
 
-       if (cmode <= ARRAY_SIZE(mv88e6185_phy_interface_modes) &&
+       if (cmode < ARRAY_SIZE(mv88e6185_phy_interface_modes) &&
            mv88e6185_phy_interface_modes[cmode])
                __set_bit(mv88e6185_phy_interface_modes[cmode],
                          config->supported_interfaces);