rtc: pcf85363: use IRQ flags obtained fromfwnode
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Mon, 23 Jan 2023 20:02:13 +0000 (21:02 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Wed, 1 Feb 2023 08:13:35 +0000 (09:13 +0100)
Allow the IRQ type to be passed from the device tree if available as there
may be components changing the trigger type of the interrupt between the
RTC and the IRQ controller.

Link: https://lore.kernel.org/r/20230123200217.1236011-8-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-pcf85363.c

index c05b722f006058f2340a787a6c8d68dcd86e51a2..5de323acd1786a8923711761ea0c9debf42bc603 100644 (file)
@@ -400,12 +400,17 @@ static int pcf85363_probe(struct i2c_client *client)
        clear_bit(RTC_FEATURE_ALARM, pcf85363->rtc->features);
 
        if (client->irq > 0) {
+               unsigned long irqflags = IRQF_TRIGGER_LOW;
+
+               if (dev_fwnode(&client->dev))
+                       irqflags = 0;
+
                regmap_write(pcf85363->regmap, CTRL_FLAGS, 0);
                regmap_update_bits(pcf85363->regmap, CTRL_PIN_IO,
                                   PIN_IO_INTA_OUT, PIN_IO_INTAPM);
                ret = devm_request_threaded_irq(&client->dev, client->irq,
                                                NULL, pcf85363_rtc_handle_irq,
-                                               IRQF_TRIGGER_LOW | IRQF_ONESHOT,
+                                               irqflags | IRQF_ONESHOT,
                                                "pcf85363", client);
                if (ret)
                        dev_warn(&client->dev, "unable to request IRQ, alarms disabled\n");