soc: mediatek: pm-domains: Don't print an error if child domain is deferred
authorEnric Balletbo i Serra <enric.balletbo@collabora.com>
Wed, 13 Jan 2021 21:30:12 +0000 (22:30 +0100)
committerMatthias Brugger <matthias.bgg@gmail.com>
Sun, 31 Jan 2021 14:59:16 +0000 (15:59 +0100)
Child domains can be deferred by the core because one of its resources
is not available yet, in such case, it will print an error, but
later it will succeed to probe. Fix that using the dev_err_probe()
function so it only prints an error on a real error.

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Reviewed-by: Hsin-Yi Wang <hsinyi@chromium.org>
Link: https://lore.kernel.org/r/20210113213012.67643-1-enric.balletbo@collabora.com
Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
drivers/soc/mediatek/mtk-pm-domains.c

index 905ac8a0341a68077940491239b0c14924eb047f..b7f697666bdd78df120f03ff1b293c3f5125971b 100644 (file)
@@ -487,8 +487,8 @@ static int scpsys_add_subdomain(struct scpsys *scpsys, struct device_node *paren
 
                child_pd = scpsys_add_one_domain(scpsys, child);
                if (IS_ERR(child_pd)) {
-                       ret = PTR_ERR(child_pd);
-                       dev_err(scpsys->dev, "%pOF: failed to get child domain id\n", child);
+                       dev_err_probe(scpsys->dev, PTR_ERR(child_pd),
+                                     "%pOF: failed to get child domain id\n", child);
                        goto err_put_node;
                }