Input: soc_button_array - properly map usage 0x07/0xe3 to KEY_LEFTMETA
authorHans de Goede <hdegoede@redhat.com>
Tue, 11 Apr 2017 03:34:19 +0000 (20:34 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 11 Apr 2017 03:41:37 +0000 (20:41 -0700)
When submitting the support for the ACPI0011 windows tablet keys device I
mapped the "windows" logo homekey to KEY_HOMEPAGE. But this is inconsistent
with how it is done on windows tablets using the old PNP0C40 ACPI device
and it does not match the HUT spec, which says that usage-page 7 usage 0xe3
is "Keyboard Left GUI".

This commit maps usage-page 7 usage 0xe3 to KEY_LEFTMETA fixing this.

Fixes: 4c3362f44980 ("Input: soc_button_array - add support for ACPI 6.0...")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/soc_button_array.c

index 95b787a6356082de0c730bb411c377c3e3d7449d..f210a33225598f19ac0891eec7d48c8cc152af75 100644 (file)
@@ -187,7 +187,7 @@ static int soc_button_parse_btn_desc(struct device *dev,
                info->wakeup = true;
        } else if (upage == 0x07 && usage == 0xe3) {
                info->name = "home";
-               info->event_code = KEY_HOMEPAGE;
+               info->event_code = KEY_LEFTMETA;
                info->wakeup = true;
        } else if (upage == 0x0c && usage == 0xe9) {
                info->name = "volume_up";