ipv4: use RCU protection in rt_is_expired()
authorEric Dumazet <edumazet@google.com>
Wed, 5 Feb 2025 15:51:13 +0000 (15:51 +0000)
committerJakub Kicinski <kuba@kernel.org>
Fri, 7 Feb 2025 00:14:14 +0000 (16:14 -0800)
rt_is_expired() must use RCU protection to make
sure the net structure it reads does not disappear.

Fixes: e84f84f27647 ("netns: place rt_genid into struct net")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20250205155120.1676781-6-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/route.c

index 74c074f45758be5ae78a87edb31837481cc40278..e959327c0ba8979ce5c7ca8c46ae41068824edc6 100644 (file)
@@ -390,7 +390,13 @@ static inline int ip_rt_proc_init(void)
 
 static inline bool rt_is_expired(const struct rtable *rth)
 {
-       return rth->rt_genid != rt_genid_ipv4(dev_net(rth->dst.dev));
+       bool res;
+
+       rcu_read_lock();
+       res = rth->rt_genid != rt_genid_ipv4(dev_net_rcu(rth->dst.dev));
+       rcu_read_unlock();
+
+       return res;
 }
 
 void rt_cache_flush(struct net *net)