video: of: display_timing: remove two unsafe error messages
authorLucas Stach <l.stach@pengutronix.de>
Tue, 13 May 2014 12:58:21 +0000 (14:58 +0200)
committerTomi Valkeinen <tomi.valkeinen@ti.com>
Thu, 15 May 2014 10:47:11 +0000 (13:47 +0300)
The error message would try to dereference the pointer that
just has been tested to be NULL. As those messages don't
really add any value without the info that the np could
provide, just remove them.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
drivers/video/of_display_timing.c

index ba5b40f581f6fdfe1849a3d4d62c8f38ea65dab1..3dc93cfacd477cd283d1e14b633365217a27caa7 100644 (file)
@@ -115,10 +115,8 @@ int of_get_display_timing(struct device_node *np, const char *name,
 {
        struct device_node *timing_np;
 
-       if (!np) {
-               pr_err("%s: no devicenode given\n", of_node_full_name(np));
+       if (!np)
                return -EINVAL;
-       }
 
        timing_np = of_get_child_by_name(np, name);
        if (!timing_np) {
@@ -142,10 +140,8 @@ struct display_timings *of_get_display_timings(struct device_node *np)
        struct device_node *native_mode;
        struct display_timings *disp;
 
-       if (!np) {
-               pr_err("%s: no device node given\n", of_node_full_name(np));
+       if (!np)
                return NULL;
-       }
 
        timings_np = of_get_child_by_name(np, "display-timings");
        if (!timings_np) {