Input: mouse - use sizeof(*pointer) instead of sizeof(type)
authorErick Archer <erick.archer@outlook.com>
Mon, 3 Jun 2024 04:30:36 +0000 (21:30 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 3 Jun 2024 04:32:02 +0000 (21:32 -0700)
It is preferred to use sizeof(*pointer) instead of sizeof(type)
due to the type of the variable can change and one needs not
change the former (unlike the latter). This patch has no effect
on runtime behavior.

Signed-off-by: Erick Archer <erick.archer@outlook.com>
Link: https://lore.kernel.org/r/AS8PR02MB7237FB736DBF67A58798FDF38BFE2@AS8PR02MB7237.eurprd02.prod.outlook.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
14 files changed:
drivers/input/mouse/alps.c
drivers/input/mouse/appletouch.c
drivers/input/mouse/bcm5974.c
drivers/input/mouse/cypress_ps2.c
drivers/input/mouse/focaltech.c
drivers/input/mouse/hgpk.c
drivers/input/mouse/lifebook.c
drivers/input/mouse/maplemouse.c
drivers/input/mouse/psmouse-base.c
drivers/input/mouse/sentelic.c
drivers/input/mouse/sermouse.c
drivers/input/mouse/synaptics.c
drivers/input/mouse/synaptics_i2c.c
drivers/input/mouse/vsxxxaa.c

index e2c11d9f3868f3ea2ec05a4230472070e32d20a4..d5ef5a112d6f034928b3dd327b0c4e9629a487ab 100644 (file)
@@ -3201,7 +3201,7 @@ int alps_detect(struct psmouse *psmouse, bool set_properties)
         */
        psmouse_reset(psmouse);
 
-       priv = kzalloc(sizeof(struct alps_data), GFP_KERNEL);
+       priv = kzalloc(sizeof(*priv), GFP_KERNEL);
        if (!priv)
                return -ENOMEM;
 
index 627048bc6a12e0ed3c2e62a36ca52159ca331efc..e669f86f1882e72bf01adbde9b9bfd1afb443ae7 100644 (file)
@@ -855,7 +855,7 @@ static int atp_probe(struct usb_interface *iface,
        }
 
        /* allocate memory for our device state and initialize it */
-       dev = kzalloc(sizeof(struct atp), GFP_KERNEL);
+       dev = kzalloc(sizeof(*dev), GFP_KERNEL);
        input_dev = input_allocate_device();
        if (!dev || !input_dev) {
                dev_err(&iface->dev, "Out of memory\n");
index ca150618d32f1863795f390b4ebf4687ea0e36c1..10a03a56690588a2ed68b86dd054acd977708bf5 100644 (file)
@@ -904,7 +904,7 @@ static int bcm5974_probe(struct usb_interface *iface,
        cfg = bcm5974_get_config(udev);
 
        /* allocate memory for our device state and initialize it */
-       dev = kzalloc(sizeof(struct bcm5974), GFP_KERNEL);
+       dev = kzalloc(sizeof(*dev), GFP_KERNEL);
        input_dev = input_allocate_device();
        if (!dev || !input_dev) {
                dev_err(&iface->dev, "out of memory\n");
index d272f1ec27ba50f5adbaaea04e2f881f3715c2ca..c693130bef4144c3b0f707ca93495960adab6b25 100644 (file)
@@ -659,7 +659,7 @@ int cypress_init(struct psmouse *psmouse)
 {
        struct cytp_data *cytp;
 
-       cytp = kzalloc(sizeof(struct cytp_data), GFP_KERNEL);
+       cytp = kzalloc(sizeof(*cytp), GFP_KERNEL);
        if (!cytp)
                return -ENOMEM;
 
index c74b99077d16a35637c1d0c015a772cea687c13b..356b99d485443f3377d931a8b7d8597fb9a6a663 100644 (file)
@@ -408,8 +408,7 @@ int focaltech_init(struct psmouse *psmouse)
        struct focaltech_data *priv;
        int error;
 
-       psmouse->private = priv = kzalloc(sizeof(struct focaltech_data),
-                                         GFP_KERNEL);
+       psmouse->private = priv = kzalloc(sizeof(*priv), GFP_KERNEL);
        if (!priv)
                return -ENOMEM;
 
index 3c8310da0b05376c46e1a6fc424c47087fa1f3e5..6125652e5ad8ea66a1cb3525dfad162806a54f73 100644 (file)
@@ -981,7 +981,7 @@ int hgpk_init(struct psmouse *psmouse)
        struct hgpk_data *priv;
        int err;
 
-       priv = kzalloc(sizeof(struct hgpk_data), GFP_KERNEL);
+       priv = kzalloc(sizeof(*priv), GFP_KERNEL);
        if (!priv) {
                err = -ENOMEM;
                goto alloc_fail;
index bd99557301760e5ce63cc1b788305c6a5dbc7029..7147dacc404f1605fcfa4ed3a153e06817a897b2 100644 (file)
@@ -273,7 +273,7 @@ static int lifebook_create_relative_device(struct psmouse *psmouse)
        struct lifebook_data *priv;
        int error = -ENOMEM;
 
-       priv = kzalloc(sizeof(struct lifebook_data), GFP_KERNEL);
+       priv = kzalloc(sizeof(*priv), GFP_KERNEL);
        dev2 = input_allocate_device();
        if (!priv || !dev2)
                goto err_out;
index 2de64d6a04d140bc7074ee82397c7d279c1197df..baef4be14b54d5e3cef152fd78cc82b87e2e44ef 100644 (file)
@@ -73,7 +73,7 @@ static int probe_maple_mouse(struct device *dev)
        struct input_dev *input_dev;
        struct dc_mouse *mse;
 
-       mse = kzalloc(sizeof(struct dc_mouse), GFP_KERNEL);
+       mse = kzalloc(sizeof(*mse), GFP_KERNEL);
        if (!mse) {
                error = -ENOMEM;
                goto fail;
index a0aac76b1e41dd91327a1cf44d8fdc2525dd18d9..a2c9f7144864e4725e377c1ad904e7dc6f873e9b 100644 (file)
@@ -1591,7 +1591,7 @@ static int psmouse_connect(struct serio *serio, struct serio_driver *drv)
                psmouse_deactivate(parent);
        }
 
-       psmouse = kzalloc(sizeof(struct psmouse), GFP_KERNEL);
+       psmouse = kzalloc(sizeof(*psmouse), GFP_KERNEL);
        input_dev = input_allocate_device();
        if (!psmouse || !input_dev)
                goto err_free;
index 2716d2ba386a15a6ae0aea9c9cf5b706f850e37c..44b136fc29aaf09422e9e133cfcda7fd641af949 100644 (file)
@@ -1028,7 +1028,7 @@ int fsp_init(struct psmouse *psmouse)
                     "Finger Sensing Pad, hw: %d.%d.%d, sn: %x, sw: %s\n",
                     ver >> 4, ver & 0x0F, rev, sn, fsp_drv_ver);
 
-       psmouse->private = priv = kzalloc(sizeof(struct fsp_data), GFP_KERNEL);
+       psmouse->private = priv = kzalloc(sizeof(*priv), GFP_KERNEL);
        if (!priv)
                return -ENOMEM;
 
index 993f90333380814c4570e8665d0ca8c6c7569fa0..218c8432a13bc9addfe54a8818ee3701f7dd6795 100644 (file)
@@ -231,7 +231,7 @@ static int sermouse_connect(struct serio *serio, struct serio_driver *drv)
        unsigned char c = serio->id.extra;
        int err = -ENOMEM;
 
-       sermouse = kzalloc(sizeof(struct sermouse), GFP_KERNEL);
+       sermouse = kzalloc(sizeof(*sermouse), GFP_KERNEL);
        input_dev = input_allocate_device();
        if (!sermouse || !input_dev)
                goto fail1;
index 7a303a9d6bf72b6e8c2e0c7086d26070fddc8ee1..38191c3b31bf512d98b88ac0a0736bfcee5590f4 100644 (file)
@@ -708,7 +708,7 @@ static void synaptics_pt_create(struct psmouse *psmouse)
 {
        struct serio *serio;
 
-       serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
+       serio = kzalloc(sizeof(*serio), GFP_KERNEL);
        if (!serio) {
                psmouse_err(psmouse,
                            "not enough memory for pass-through port\n");
@@ -1563,7 +1563,7 @@ static int synaptics_init_ps2(struct psmouse *psmouse,
 
        synaptics_apply_quirks(psmouse, info);
 
-       psmouse->private = priv = kzalloc(sizeof(struct synaptics_data), GFP_KERNEL);
+       psmouse->private = priv = kzalloc(sizeof(*priv), GFP_KERNEL);
        if (!priv)
                return -ENOMEM;
 
index 56e9ba396858570f38198e9f0ae42f96829fb08d..a0d707e47d932dd219effbcc88b5054edd30d5f0 100644 (file)
@@ -508,7 +508,7 @@ static struct synaptics_i2c *synaptics_i2c_touch_create(struct i2c_client *clien
 {
        struct synaptics_i2c *touch;
 
-       touch = kzalloc(sizeof(struct synaptics_i2c), GFP_KERNEL);
+       touch = kzalloc(sizeof(*touch), GFP_KERNEL);
        if (!touch)
                return NULL;
 
index 8af8e4a15f95d6597a6433deb0e5e63ff5ab0508..707cd28f4ba62046b929bbaceb85f9c881366266 100644 (file)
@@ -456,7 +456,7 @@ static int vsxxxaa_connect(struct serio *serio, struct serio_driver *drv)
        struct input_dev *input_dev;
        int err = -ENOMEM;
 
-       mouse = kzalloc(sizeof(struct vsxxxaa), GFP_KERNEL);
+       mouse = kzalloc(sizeof(*mouse), GFP_KERNEL);
        input_dev = input_allocate_device();
        if (!mouse || !input_dev)
                goto fail1;