zram: pass estimated src size hint to zstd
authorSergey Senozhatsky <senozhatsky@chromium.org>
Mon, 2 Sep 2024 10:55:57 +0000 (19:55 +0900)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 9 Sep 2024 23:39:08 +0000 (16:39 -0700)
zram works with PAGE_SIZE buffers, so we always know exact size of the
source buffer and hence can pass estimated_src_size to zstd_get_params().

This hint on x86_64, for example, reduces the size of the work memory
buffer from 1303520 bytes down to 90080 bytes.  Given that compression
streams are per-CPU that's quite some memory saving.

Link: https://lkml.kernel.org/r/20240902105656.1383858-10-senozhatsky@chromium.org
Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Nick Terrell <terrelln@fb.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/block/zram/backend_zstd.c

index abec68d1104b38b550ee150ee7cf46d808c24254..310d970078e205590e4d9b1c24b179484e49a5dd 100644 (file)
@@ -35,7 +35,7 @@ static void *zstd_create(void)
                return NULL;
 
        ctx->level = zstd_default_clevel();
-       params = zstd_get_params(ctx->level, 0);
+       params = zstd_get_params(ctx->level, PAGE_SIZE);
        sz = zstd_cctx_workspace_bound(&params.cParams);
        ctx->cctx_mem = vzalloc(sz);
        if (!ctx->cctx_mem)
@@ -65,7 +65,7 @@ static int zstd_compress(void *ctx, const unsigned char *src, size_t src_len,
                         unsigned char *dst, size_t *dst_len)
 {
        struct zstd_ctx *zctx = ctx;
-       const zstd_parameters params = zstd_get_params(zctx->level, 0);
+       const zstd_parameters params = zstd_get_params(zctx->level, PAGE_SIZE);
        size_t ret;
 
        ret = zstd_compress_cctx(zctx->cctx, dst, *dst_len,