powerpc: Use set_trap() and avoid open-coding trap masking

The pt_regs.trap field keeps 4 low bits for some metadata about the
trap or how it was handled, which is masked off in order to test the
architectural trap number.

Add a set_trap() accessor to set this, equivalent to TRAP() for
returning it. This is actually not quite the equivalent of TRAP()
because it always clears the low bits, which may be harmless if
it can only be updated via ptrace syscall, but it seems dangerous.

In fact settting TRAP from ptrace doesn't seem like a great idea
so maybe it's better deleted.

Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
[mpe: Make it a static inline rather than a shouty macro]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200507121332.2233629-2-mpe@ellerman.id.au

diff --git a/arch/powerpc/include/asm/ptrace.h b/arch/powerpc/include/asm/ptrace.h
index 89f31d5a80629fc945bac069272bfba79b83664e..7c585bddc06e1c83ccec8960e7098619901433de 100644 (file)
--- a/arch/powerpc/include/asm/ptrace.h
+++ b/arch/powerpc/include/asm/ptrace.h
@@ -182,10 +182,12 @@ extern int ptrace_put_reg(struct task_struct *task, int regno,
 
 #ifdef __powerpc64__
 #ifdef CONFIG_PPC_BOOK3S
+#define TRAP_FLAGS_MASK                0
 #define TRAP(regs)             ((regs)->trap)
 #define FULL_REGS(regs)                true
 #define SET_FULL_REGS(regs)    do { } while (0)
 #else
+#define TRAP_FLAGS_MASK                0x1
 #define TRAP(regs)             ((regs)->trap & ~0x1)
 #define FULL_REGS(regs)                (((regs)->trap & 1) == 0)
 #define SET_FULL_REGS(regs)    ((regs)->trap |= 1)
@@ -200,6 +202,7 @@ extern int ptrace_put_reg(struct task_struct *task, int regno,
  * On 4xx we use the next bit to indicate whether the exception
  * is a critical exception (1 means it is).
  */
+#define TRAP_FLAGS_MASK                0xF
 #define TRAP(regs)             ((regs)->trap & ~0xF)
 #define FULL_REGS(regs)                (((regs)->trap & 1) == 0)
 #define SET_FULL_REGS(regs)    ((regs)->trap |= 1)
@@ -214,6 +217,11 @@ do {                                                                             \
 } while (0)
 #endif /* __powerpc64__ */
 
+static inline void set_trap(struct pt_regs *regs, unsigned long val)
+{
+       regs->trap = (regs->trap & TRAP_FLAGS_MASK) | (val & ~TRAP_FLAGS_MASK);
+}
+
 #define arch_has_single_step() (1)
 #ifndef CONFIG_BOOK3S_601
 #define arch_has_block_step()  (true)

diff --git a/arch/powerpc/kernel/ptrace/ptrace-tm.c b/arch/powerpc/kernel/ptrace/ptrace-tm.c
index d75aff31f6379fe072d5d2de35a35596b3d19de1..32d62c606681e00c1fc7f7d3a80bd2bbce686386 100644 (file)
--- a/arch/powerpc/kernel/ptrace/ptrace-tm.c
+++ b/arch/powerpc/kernel/ptrace/ptrace-tm.c
@@ -43,7 +43,7 @@ static int set_user_ckpt_msr(struct task_struct *task, unsigned long msr)
 
 static int set_user_ckpt_trap(struct task_struct *task, unsigned long trap)
 {
-       task->thread.ckpt_regs.trap = trap & 0xfff0;
+       set_trap(&task->thread.ckpt_regs, trap);
        return 0;
 }
 

diff --git a/arch/powerpc/kernel/ptrace/ptrace-view.c b/arch/powerpc/kernel/ptrace/ptrace-view.c
index 15e3b79b639528a9cbdbe374c2e5b3675c84a33f..caeb5822a8f4a6ba32f7975cf5842f01a16381b2 100644 (file)
--- a/arch/powerpc/kernel/ptrace/ptrace-view.c
+++ b/arch/powerpc/kernel/ptrace/ptrace-view.c
@@ -149,7 +149,7 @@ static int set_user_dscr(struct task_struct *task, unsigned long dscr)
  */
 static int set_user_trap(struct task_struct *task, unsigned long trap)
 {
-       task->thread.regs->trap = trap & 0xfff0;
+       set_trap(task->thread.regs, trap);
        return 0;
 }
 

diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index 7af840c0fc933b3b55b8c1b3336f691f72981085..92761e47fb5cbc0b902fa5b760a203d3d2d94118 100644 (file)
--- a/arch/powerpc/xmon/xmon.c
+++ b/arch/powerpc/xmon/xmon.c
@@ -1178,7 +1178,7 @@ static int do_step(struct pt_regs *regs)
                                return 0;
                        }
                        if (stepped > 0) {
-                               regs->trap = 0xd00 | (regs->trap & 1);
+                               set_trap(regs, 0xd00);
                                printf("stepped to ");
                                xmon_print_symbol(regs->nip, " ", "\n");
                                ppc_inst_dump(regs->nip, 1, 0);