staging: rtl8192e: Remove unexecuted rtllib_extract_country_ie()
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Sun, 19 Nov 2023 22:14:36 +0000 (23:14 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Nov 2023 12:46:27 +0000 (12:46 +0000)
Variable "enabled" is initialized to false and never changed. Therefore
IS_DOT11D_ENABLE(ieee) returns always false. Because of this all code in
rtllib_extract_country_ie() is never executed.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/7b88c62d3cc5c3fb670b5448c7381c7c099b3518.1700431464.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtllib_rx.c

index ecaa4dec3f944b1dc4ea53cd6eebb7719d7f9fc5..d9517dbc5593b474144a8cc86b4ad9d179a4a739 100644 (file)
@@ -1663,35 +1663,6 @@ static const char *get_info_element_string(u16 id)
        }
 }
 
-static inline void rtllib_extract_country_ie(
-       struct rtllib_device *ieee,
-       struct rtllib_info_element *info_element,
-       struct rtllib_network *network,
-       u8 *addr2)
-{
-       if (IS_DOT11D_ENABLE(ieee)) {
-               if (info_element->len != 0) {
-                       memcpy(network->CountryIeBuf, info_element->data,
-                              info_element->len);
-                       network->CountryIeLen = info_element->len;
-
-                       if (!IS_COUNTRY_IE_VALID(ieee)) {
-                               if (rtllib_act_scanning(ieee, false) &&
-                                   ieee->FirstIe_InScan)
-                                       netdev_info(ieee->dev,
-                                                   "Received beacon CountryIE, SSID: <%s>\n",
-                                                   network->ssid);
-                               dot11d_update_country(ieee, addr2,
-                                                      info_element->len,
-                                                      info_element->data);
-                       }
-               }
-
-               if (IS_EQUAL_CIE_SRC(ieee, addr2))
-                       UPDATE_CIE_WATCHDOG(ieee);
-       }
-}
-
 static void rtllib_parse_mife_generic(struct rtllib_device *ieee,
                                      struct rtllib_info_element *info_element,
                                      struct rtllib_network *network,
@@ -2146,8 +2117,6 @@ int rtllib_parse_info_param(struct rtllib_device *ieee,
                case MFIE_TYPE_COUNTRY:
                        netdev_dbg(ieee->dev, "MFIE_TYPE_COUNTRY: %d bytes\n",
                                   info_element->len);
-                       rtllib_extract_country_ie(ieee, info_element, network,
-                                                 network->bssid);
                        break;
 /* TODO */
                default: